Add Kiwix server a few accesskeys #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
=======================================
Coverage 40.93% 40.93%
=======================================
Files 58 58
Lines 4204 4204
Branches 2307 2307
=======================================
Hits 1721 1721
Misses 1015 1015
Partials 1468 1468 ☔ View full report in Codecov by Sentry. |
veloman-yunkan
approved these changes
May 7, 2024
|
This is a approval but waiting feedback from user as requested here : openzim/mwoffliner#2023 (comment) |
kelson42
force-pushed
the
kiwix-server-accesskeys
branch
from
0b6808a
to
2964cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1072
Except for the "Library" button, the accesskey values are the same as on Kiwix Desktop or should be implemented the same (like for input search and switch to library) in Kiwix Desktop, see kiwix/kiwix-desktop#1083. This is the reason why I don't have respected exactly the request like requested by @patrick-emmabuntus.