Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Feature/124 #141

Merged
merged 90 commits into from
Nov 21, 2019
Merged

Testing Feature/124 #141

merged 90 commits into from
Nov 21, 2019

Conversation

Robbie1977
Copy link
Contributor

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

jrmartin and others added 30 commits August 21, 2019 06:29
@jrmartin
Merge remote-tracking branch 'origin/development' into feature/35
f949218
@afonsobspinto
Fix tutorial name issue
3932427
@afonsobspinto
Fix tutorial name issue
98c7962
@afonsobspinto
Merge branch 'feature/87' of https://github.com/openworm/geppetto-client
e0f3a27 
 into feature/87
@afonsobspinto
Fix guid error
caed777
@jrmartin
Merge branch 'feature/35' of https://github.com/openworm/geppetto-cli…
0787867 
…ent.git into feature/35
@jrmartin
Merge remote-tracking branch 'origin/development' into feature/35
0808020
@jrmartin
test using off() before on() for events
e1f093a
@jrmartin
adding off before on to avoid duplicate listener on geppetto events
387a7db
@jrmartin
linting fix
8a05885
@jrmartin
undo changes, not needed on all on() apparently
a2c1801
@jrmartin
off before on for all
0587706
@jrmartin
Remove all jquery's off() before on(), not going to work since it
403d172 
overwrites the same events that were added in other React classes and
not the ones just added in here
@ddelpiano
fixed tree widget data update, fixed tutorial component due to the we…
10ca4bf 
…bpack upgrade
@jrmartin
unattach GEPPETTO.EVENTS from listeners when component gets unmounted
7cfe77b
@jrmartin
test by commenting out all the off listeners minus the delete one
c6037c2
@jrmartin
test, indent fix
2c29d2e
@jrmartin
another test
a3b1a11
@jrmartin
test indent
a763496
@jrmartin
linting fixes for test
237637d
@jrmartin
test
a3cb697
@jrmartin
Some refactoring of the way we attach listeners in componentdidmount of
668c547 
experiment table, and then unmount the same events in
componentwillunmount to prevent them from firing again
@jrmartin
cleaning and making eslint happy
88b49d9
@ddelpiano
latest on tree components
0a743d9
@jrmartin
work in progress trying to fix clearAll bugs
e0fda7f
@jrmartin
fix delete images in slice viewer and clean control panel lines
a4334bd
@jrmartin
Merge remote-tracking branch 'origin/development' into geppetto_vfb/f…
3c72f5c 
…eature/218
@jrmartin
merge some changes from feature/101 that i delete by mistake
55c84b0
@jrmartin
move error modal messages to resources file
a07ff49
@jrmartin
imports resource file
c2e73df
tarelli and others added 29 commits November 12, 2019 10:50
@tarelli
Merge pull request #118 from openworm/fix/115
a4878c5 
stackviewer bug on reopening fixed
@tarelli
Merge pull request #106 from openworm/feature/105
42193b5 
Feature/105
@tarelli
Merge pull request #112 from openworm/feature/110
16eadaf 
Feature/110
@tarelli
Merge pull request #117 from openworm/feature/116
ff38252 
tooltip re-alignment between buttonbar, focusterm and other components
@tarelli
Merge branch 'development' into geppetto_vfb/feature/218
6227e16
@tarelli
Merge pull request #109 from openworm/geppetto_vfb/feature/218
8a3bbaf 
Geppetto vfb/feature/218
#129 Include custom filter component for listView
a572632
@filippomc
Merge branch 'feature/119' of https://github.com/openworm/geppetto-cl…
c5ed883 
…ient into feature/119
@filippomc
Merge last dev changes
e472ab8
@filippomc
#119 Fix post merge require error
7a847ff
@tarelli
Merge pull request #122 from openworm/feature/119
63e7871 
Feature/119
#126 Add radial force to prevent unlinked nodes from scattering
815a4f1
#126 Set camera centering time to 0
7bb3047
#126 bump three version to ^0.110.0
579140c
#126 Remove react-forcegraph-vr package
28f6d3d
@filippomc
#132 Adjusting merge with worlds
1bc4f9b
@filippomc
#132 Fixed merge value
fab8991
@filippomc
#132 Fixed merge - unit tests OK
61208d8
@filippomc
#132 added fetch tests
1fa3487
#126 Back to THREE version 0.87.1
3542cdc
@filippomc
#132 small cleaning/comments
11b0d55
@tarelli
Merge pull request #133 from openworm/feature/126
4f69841 
Feature/126
@tarelli
Merge pull request #134 from openworm/feature/132
8c2ca86 
Feature/132 add fetch on new model
@filippomc
Fixed graph labels
8eaee5d
@tarelli
Merge pull request #136 from openworm/feature/132
8879847 
Fixed graph labels
@filippomc
#132 fix ModelFactory
6fb5df5
@tarelli
Merge pull request #137 from openworm/feature/fix/132
20d56ac 
#132 fix ModelFactory
@Robbie1977
Merge pull request #140 from openworm/development
c057ab2 
updates from Development
@Robbie1977
removing delay
0a1c60e
@Robbie1977 Robbie1977 merged commit 2c16094 into vfb_geppetto_application Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Robbie1977 @jrmartin @afonsobspinto @ddelpiano @filippomc @tarelli