Feature/126 #133
Merged
Feature/126 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filippomc
commented
Nov 18, 2019
filippomc
commented
- Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
- Make sure both push and pr travis builds are passing before asking for a review
|
@rodriguez-facundo is this ready to merge? |
|
It is bumping three from 87 to 110... I don't feel comfortable with that. But @tarelli said "if tests are passing, it is ok". What if I try to come back to 87 and see if it works now that I removed the problematic package |
|
Went back to THREE v 0.87.1. This is ready to be merged. |
tarelli
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.