Feature/105 #106
Merged
Feature/105 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overwrites the same events that were added in other React classes and not the ones just added in here
experiment table, and then unmount the same events in componentwillunmount to prevent them from firing again
|
@tarelli ready to be reviewed |
|
@tarelli this can be merged |
tarelli
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #105 . It adds React method componentDidUnmount() to Experiments Table , so that Events listeners get detach when component gets unmounted. PR doesn't solve the issue of TabbedDrawer children components (Console and Experiment Table) getting rendered twice, but it solves the problems generated by it since Events Listeners won't fire on unmounted component.
Tested in persistence bundle against caspers:
https://travis-ci.org/openworm/org.geppetto.persistence/builds/591626520
Tested in persistence bundle against jest:
https://travis-ci.org/openworm/org.geppetto.persistence/builds/591632888
Tested in geppetto-application against jest-puppeteer tests in branch feature_14:
https://travis-ci.org/openworm/geppetto-application/builds/591648676
closes #105