METAL-1094: Sync with upstream metal3-io/ironic-image #532
Conversation
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
⚠️ Completely remove support for ironic-inspector
Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
…main 🌱 Fix error in reading ironic htpasswd from file
Loading the "flat" network interfaces caues a confusing warnings about unset cleaning_network parameter. Just disable it. Sort the options in the configuration. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: NymanRobin <robin.nyman@est.tech>
…for-image-building-failures 🌱 Add Slack notification for image build workflow failure
OWNERS_ALIASES groups are needed for fair blunderbuss review requests. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
🌱 add OWNERS_ALIASES support
🐛 Disable unused network interfaces
Make shellcheck consider only files. If branch name ended with .sh or .sh/something, it was found on the filesystem as something ending with .sh, and shellcheck picked it up, and linting faield obviously. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
…main 🌱 Read Ironic htpasswd from file or environment variable
🌱 shellcheck only files
Ironic-image build locally, with a fast disk, fast CPU, and fast net takes 500-600s, depending on pre-pulls, repository speeds etc. New cloud has none of those reliably, so it times out at 1000s far too often. Ironic image: 1000s -> 3600s (build time 500-600s) Sushy-tools: keep 1000s (build time 150s, 6x safety) VMBC: keep 1000s (build time 100s, 10x safety) Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
…ld-timeout 🌱 increase ironic-image build timeout to 3600s
Also update pip install commands where needed Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
Introduce variable to set build container engine. Build with podman by default. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
🌱 Update Makefile
🌱 Update pip version
openshift-ci
bot
added
the
do-not-merge/invalid-owners-file
MahnoorAsghar
force-pushed
the
sync
branch
2 times, most recently
from
9c9261a to
8a9d393
Compare
openshift-ci
bot
removed
the
do-not-merge/invalid-owners-file
|
I tried to get rid of the Makefile change, with little success ^ |
MahnoorAsghar
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@MahnoorAsghar: This pull request references METAL-886 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
MahnoorAsghar
changed the title
|
@MahnoorAsghar: This pull request references METAL-1094 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/approve |
elfosardo
added
acknowledge-critical-fixes-only
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/cc @dtantsur |
|
@MahnoorAsghar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo, MahnoorAsghar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
[ART PR BUILD NOTIFIER] Distgit: ironic |
openshift#532 removes ironic inspector but missed scos and fcos dockerfiles
openshift#532 removes ironic inspector but missed scos and fcos dockerfiles
🐛 Update httpd.conf.j2
No description provided.