[DNM] Testing fix for issue in reading htpasswd from files #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is not specific to inspection, let alone its ironic-inspector implementation. Rename to IRONIC_ENABLE_VLAN_INTERFACES. The old name is still supported but deprecated. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
🌱 Rename IRONIC_INSPECTOR_VLAN_INTERFACES
Allow auto-discovery to be enabled with the built-in inspection. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
The tripleo repo has been archived as tripleo is not maintained anymore. Let's switch to RDO repos for vbmc to avoid breakage. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
🐛 Fix vbmc container build after tripleo deprecation
⚠️ Disable ironic-inspector by default
Shellcheck had its first release since 2022, so bump it. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
🌱 bump shellcheck to v0.10.0
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Both drivers (in case of idrac - its wsman implementation) has been unmaintained for years, same for their underlying libraries ibmcclient [1] and dracclient [2]. Ironic has deprecated them in the 2024.1 cycle. Dell users should use idrac-redfish:// and idrac-virtualmedia:// instead. iBMC users should try using the generic Redfish drivers and report any bugs to the Ironic team and any standard compatibility problems directly to Huawei. [1] https://github.com/IamFive/python-ibmcclient [2] https://opendev.org/openstack/python-dracclient Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
⚠️ Remove support for API/conductor split
⚠️ Remove ibmc and idrac drivers
Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
This should reduce the size of the image from 400MB to 290MB Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
To be consistent with other Dockerfiles, and to allow easy replacement of the base image, add ARG BASE_IMAGE to sushy-tools Dockerfile. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
…-arg 🌱 add ARG BASE_IMAGE to sushy-tools Dockerfile
🌱 Bump sushy-tools version to 1.2.0
🌱 Build virtualbmc image using python image
This change is the first step towards metal3-io/baremetal-operator#1528. Through these scripts, we can decouple the validation logic from the pod definition and provide more sophisticated tests in the future. Right now, the same curl command is used (modulo supporting all variants of deploying Ironic). Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
✨ Provide scripts to be used as liveness/readiness probes
Using additional ports increase the chance of conflicting with something else on the node and is also potentially less efficient. We have used Unix sockets via a shared directory in OpenShift for a while without any complaints. I think upstream should do the same. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
⚠️ Use unix sockets by default for reverse proxy communication
Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
🐛 Stop reading ironic and inspector HTPASSWD from environment variables
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MahnoorAsghar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MahnoorAsghar
force-pushed
the
read-htpasswd
branch
from
13ee411 to
5499aa2
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest-required |
|
/test e2e-metal-ipi-bm |
Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
MahnoorAsghar
force-pushed
the
read-htpasswd
branch
from
5499aa2 to
13348ae
Compare
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@MahnoorAsghar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
MahnoorAsghar
pushed a commit
to MahnoorAsghar/ironic-image
that referenced
this pull request
Jul 23, 2024
⚠️ Completely remove support for ironic-inspector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.