Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: fix scos and fcos dockerfiles to remove ironic-inspector #566

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Prashanth684
Copy link

#532 removes ironic inspector but missed scos and fcos dockerfiles

openshift#532  removes ironic
inspector but missed scos and fcos dockerfiles
@Prashanth684
Copy link
Author

this affects openshift/release#55886 and is needed for the okd release.

@ausil
Copy link

ausil commented Aug 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
Copy link

openshift-ci bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo elfosardo added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 23, 2024
@elfosardo
Copy link

/override ci/prow/e2e-metal-ipi-virtualmedia

Copy link

openshift-ci bot commented Aug 23, 2024

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/e2e-metal-ipi-virtualmedia

In response to this:

/override ci/prow/e2e-metal-ipi-virtualmedia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Aug 23, 2024

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@elfosardo elfosardo changed the title fix scos and fcos dockerfiles to remove ironic-inspector NO-ISSUE: fix scos and fcos dockerfiles to remove ironic-inspector Aug 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 23, 2024
@openshift-ci-robot
Copy link

@Prashanth684: This pull request explicitly references no jira issue.

In response to this:

#532 removes ironic inspector but missed scos and fcos dockerfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@elfosardo: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 599d8b4 into openshift:master Aug 23, 2024
6 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ironic
This PR has been included in build ironic-container-v4.18.0-202408230910.p0.g599d8b4.assembly.stream.el9.
All builds following this will include this PR.

@Prashanth684
Copy link
Author

/cherry-pick release-4.17

@openshift-cherrypick-robot

@Prashanth684: new pull request created: #567

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants