Create index pattern - modal popup #366

djindjic · 2023-01-13T20:49:13Z

Description

In place index pattern creation on surrounding documents requested

Issues Resolved

Closes #132

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

public/models/interfaces.ts

public/pages/Findings/components/CreateIndexPatternForm.tsx

public/services/OpenSearchService.ts

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic · 2023-01-19T18:56:06Z

@amsiglan

Screen.Recording.2023-01-19.at.7.52.44.PM.mov

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

public/pages/Findings/components/CreateIndexPatternForm.tsx

public/pages/Findings/components/FindingDetailsFlyout.tsx

public/plugin.ts

public/services/IndexPatternsService.ts

amsiglan · 2023-01-19T21:37:43Z

@djindjic Do you think we should hide the View surrounding documents button if the indexPatternService is not available or should it not be marked as optional?

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

codecov-commenter · 2023-01-21T09:04:24Z

Codecov Report

Merging #366 (5384c2e) into main (a03e697) will decrease coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   15.39%   15.33%   -0.07%     
==========================================
  Files         109      111       +2     
  Lines        2890     2961      +71     
  Branches      476      488      +12     
==========================================
+ Hits          445      454       +9     
- Misses       2406     2468      +62     
  Partials       39       39

Impacted Files	Coverage Δ
...ashboards-plugin/public/security_analytics_app.tsx	`5.88% <0.00%> (-0.37%)`	⬇️
...urity-analytics-dashboards-plugin/public/plugin.ts	`0.00% <0.00%> (ø)`
...ytics-dashboards-plugin/public/pages/Main/Main.tsx	`8.88% <0.00%> (ø)`
...ic/pages/Findings/containers/Findings/Findings.tsx	`9.70% <0.00%> (ø)`
...indings/components/FindingsTable/FindingsTable.tsx	`18.75% <0.00%> (ø)`
...ges/Findings/components/CreateIndexPatternForm.tsx	`13.20% <0.00%> (ø)`
...rds-plugin/public/services/IndexPatternsService.ts	`0.00% <0.00%> (ø)`
...pages/Findings/components/FindingDetailsFlyout.tsx	`9.72% <0.00%> (+1.38%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic · 2023-01-22T13:18:51Z

@djindjic Do you think we should hide the View surrounding documents button if the indexPatternService is not available or should it not be marked as optional?

@amsiglan I was doubting on how to make a proper typing on injected dependencies. Seems like this is the right way: f883426

Now it is no more optional as service. Tests will cover it more

I've also created opensearch-project/OpenSearch-Dashboards#3302 on Dashboards Core docs in order to confirm it with core team guys.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

…pattern

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* create index pattern modal Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * rename props Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * typos and minor changes Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> --------- Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit 2f08f22)

* create index pattern modal Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * rename props Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * typos and minor changes Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> --------- Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit 2f08f22) Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>

…ch-project#397) * create index pattern modal Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * rename props Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * typos and minor changes Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> --------- Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit 2f08f22) Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* create index pattern modal Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * validate index pattern name and fill timeFields Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse SavedObjectsService from dashboards core Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * take title and time field from the form Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * reuse index patterns service from core dashboards Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * improve ux for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * rename props Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * submit button loading state from formik submiting Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * typos and minor changes Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * indexPatternsService marked as mandatory dep Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * better typing on injected dependencies Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * cypress test for create index pattern Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * align cypress test with new convention Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * useCallback event handler wrapper Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> --------- Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> (cherry picked from commit 2f08f22) Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>

create index pattern modal

9bf0c69

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic requested a review from a team January 13, 2023 20:49

djindjic commented Jan 13, 2023

View reviewed changes

public/models/interfaces.ts Outdated Show resolved Hide resolved

djindjic commented Jan 13, 2023

View reviewed changes

public/pages/Findings/components/CreateIndexPatternForm.tsx Outdated Show resolved Hide resolved

djindjic commented Jan 13, 2023

View reviewed changes

public/pages/Findings/components/CreateIndexPatternForm.tsx Outdated Show resolved Hide resolved

djindjic commented Jan 13, 2023

View reviewed changes

public/services/OpenSearchService.ts Outdated Show resolved Hide resolved

djindjic commented Jan 13, 2023

View reviewed changes

public/services/OpenSearchService.ts Outdated Show resolved Hide resolved

djindjic added 5 commits January 16, 2023 18:20

validate index pattern name and fill timeFields

1e4fb70

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

reuse SavedObjectsService from dashboards core

feeab62

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

take title and time field from the form

cc44b41

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

reuse index patterns service from core dashboards

31a33dc

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

improve ux for create index pattern

760da4c

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

djindjic changed the title ~~[WIP] create index pattern modal~~ Create index pattern - modal popup Jan 19, 2023

rename props

938e8e9

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>