better typing on injected dependencies

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
opensearch-project · Jan 22, 2023 · f883426 · f883426
1 parent ab586e6
commit f883426
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/public/plugin.ts b/public/plugin.ts
@@ -12,13 +12,13 @@ import {
 } from '../../../src/core/public';
 import { PLUGIN_NAME, ROUTES } from './utils/constants';
 import { SecurityAnalyticsPluginSetup, SecurityAnalyticsPluginStart } from './index';
-import { Plugin as DataPublicPlugin } from '../../../src/plugins/data/public';
+import { DataPublicPluginStart, DataPublicPluginSetup } from '../../../src/plugins/data/public';
 
 export interface SecurityAnalyticsPluginSetupDeps {
-  data: DataPublicPlugin;
+  data: DataPublicPluginSetup;
 }
 export interface SecurityAnalyticsPluginStartDeps {
-  data: DataPublicPlugin;
+  data: DataPublicPluginStart;
 }
 
 export class SecurityAnalyticsPlugin
@@ -34,7 +34,7 @@ export class SecurityAnalyticsPlugin
   }
 
   public setup(
-    core: CoreSetup,
+    core: CoreSetup<SecurityAnalyticsPluginStartDeps>,
     plugins: SecurityAnalyticsPluginSetupDeps
   ): SecurityAnalyticsPluginSetup {
     core.application.register({
@@ -49,12 +49,7 @@ export class SecurityAnalyticsPlugin
       mount: async (params: AppMountParameters) => {
         const { renderApp } = await import('./security_analytics_app');
         const [coreStart, depsStart] = await core.getStartServices();
-        return renderApp(
-          coreStart,
-          params,
-          ROUTES.LANDING_PAGE,
-          depsStart as SecurityAnalyticsPluginStartDeps
-        );
+        return renderApp(coreStart, params, ROUTES.LANDING_PAGE, depsStart);
       },
     });
     return {};

diff --git a/public/security_analytics_app.tsx b/public/security_analytics_app.tsx
@@ -42,7 +42,7 @@ export function renderApp(
   const alertsService = new AlertsService(http);
   const ruleService = new RuleService(http);
   const notificationsService = new NotificationsService(http);
-  const indexPatternsService = new IndexPatternsService((depsStart.data as any).indexPatterns);
+  const indexPatternsService = new IndexPatternsService(depsStart.data.indexPatterns);
 
   const services: BrowserServices = {
     detectorsService,