indexPatternsService marked as mandatory dep

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
opensearch-project · Jan 22, 2023 · ab586e6 · ab586e6
1 parent 1cd30fb
commit ab586e6
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 12 deletions.
diff --git a/public/models/interfaces.ts b/public/models/interfaces.ts
@@ -24,7 +24,7 @@ export interface BrowserServices {
   alertService: AlertsService;
   ruleService: RuleService;
   notificationsService: NotificationsService;
-  indexPatternsService?: IndexPatternsService;
+  indexPatternsService: IndexPatternsService;
 }
 
 export interface RuleOptions {

diff --git a/public/pages/Findings/components/CreateIndexPatternForm.tsx b/public/pages/Findings/components/CreateIndexPatternForm.tsx
@@ -35,7 +35,7 @@ export interface CreateIndexPatternFormProps {
   };
   created: (values: string) => void;
   close: () => void;
-  indexPatternsService?: IndexPatternsService;
+  indexPatternsService: IndexPatternsService;
 }
 
 export const CreateIndexPatternForm: React.FC<CreateIndexPatternFormProps> = ({
@@ -113,9 +113,6 @@ export const CreateIndexPatternForm: React.FC<CreateIndexPatternFormProps> = ({
         return errors;
       }}
       onSubmit={async (values, { setSubmitting }) => {
-        if (!indexPatternsService) {
-          return;
-        }
         try {
           const newIndex = await indexPatternsService.createAndSave({
             title: values.name,

diff --git a/public/pages/Findings/components/FindingDetailsFlyout.tsx b/public/pages/Findings/components/FindingDetailsFlyout.tsx
@@ -42,7 +42,7 @@ interface FindingDetailsFlyoutProps {
   backButton?: React.ReactNode;
   allRules: { [id: string]: RuleSource };
   opensearchService: OpenSearchService;
-  indexPatternsService?: IndexPatternsService;
+  indexPatternsService: IndexPatternsService;
   closeFlyout: () => void;
 }
 

diff --git a/public/pages/Findings/components/FindingsTable/FindingsTable.tsx b/public/pages/Findings/components/FindingsTable/FindingsTable.tsx
@@ -39,7 +39,7 @@ interface FindingsTableProps extends RouteComponentProps {
   onRefresh: () => void;
   onFindingsFiltered: (findings: FindingItemType[]) => void;
   hasNotificationsPlugin: boolean;
-  indexPatternsService?: IndexPatternsService;
+  indexPatternsService: IndexPatternsService;
 }
 
 interface FindingsTableState {

diff --git a/public/pages/Findings/containers/Findings/Findings.tsx b/public/pages/Findings/containers/Findings/Findings.tsx
@@ -60,7 +60,7 @@ interface FindingsProps extends RouteComponentProps {
   detectorService: DetectorsService;
   findingsService: FindingsService;
   notificationsService: NotificationsService;
-  indexPatternsService?: IndexPatternsService;
+  indexPatternsService: IndexPatternsService;
   opensearchService: OpenSearchService;
   ruleService: RuleService;
   notifications: NotificationsStart;

diff --git a/public/security_analytics_app.tsx b/public/security_analytics_app.tsx
@@ -30,7 +30,7 @@ export function renderApp(
   coreStart: CoreStart,
   params: AppMountParameters,
   landingPage: string,
-  plugins?: SecurityAnalyticsPluginStartDeps
+  depsStart: SecurityAnalyticsPluginStartDeps
 ) {
   const { http, savedObjects } = coreStart;
 
@@ -42,9 +42,7 @@ export function renderApp(
   const alertsService = new AlertsService(http);
   const ruleService = new RuleService(http);
   const notificationsService = new NotificationsService(http);
-  const indexPatternsService = plugins
-    ? new IndexPatternsService((plugins.data as any).indexPatterns)
-    : undefined;
+  const indexPatternsService = new IndexPatternsService((depsStart.data as any).indexPatterns);
 
   const services: BrowserServices = {
     detectorsService,