Improved typings #3302
Merged
Improved typings #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
This was referenced Jan 22, 2023
djindjic
force-pushed
the
patch-1
branch
2 times, most recently
from
1ed6818
to
8396f9d
Compare
joshuarrrr
previously approved these changes
Feb 7, 2023
There was a problem hiding this comment.
@djindjic Thanks for the contribution! This is the correct type usage we want.
The only suggestion I have is to rename both L174 and 188 from MyPluginDepsStart to MyPluginStartDeps, which is more conventional and would better match the other examples in this doc.
joshuarrrr
added
the
Skip-Changelog
Signed-off-by: Josh Romero <rmerqg@amazon.com>
abbyhu2000
approved these changes
Mar 8, 2023
joshuarrrr
approved these changes
Mar 9, 2023
|
Thanks @djindjic ! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * Nit - rename example deps prop Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Miki <miki@amazon.com> (cherry picked from commit c35dadb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
added a commit
that referenced
this pull request
Mar 9, 2023
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` * Nit - rename example deps prop --------- (cherry picked from commit c35dadb) Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Miki <miki@amazon.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * Nit - rename example deps prop Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Miki <miki@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
* Improved typings Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> * Nit - rename example deps prop Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Miki <miki@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR on docs I would actually like to confirm if this is the proper way of typing plugin dependencies.
Passing this first param to
CoreSetupgeneric would set a proper type todepsStartreturned fromcore.getStartServices()