Improved typings

Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()` Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
opensearch-project · Jan 23, 2023 · 1ed6818 · 1ed6818
1 parent 52769f2
commit 1ed6818
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/core/CONVENTIONS.md b/src/core/CONVENTIONS.md
@@ -182,10 +182,10 @@ export const renderApp = (
 ```ts
 // my_plugin/public/plugin.ts
 
-import { Plugin } from '../../src/core/public';
+import { Plugin, CoreSetup } from '../../src/core/public';
 
 export class MyPlugin implements Plugin {
-  public setup(core) {
+  public setup(core: CoreSetup<MyPluginDepsStart>) {
     core.application.register({
       id: 'my-app',
       async mount(params) {