Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle Wrapper to 7.6.1 #815

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Apr 28, 2023

Description

Upgrade Gradle version to 7.6.1 to solve build failure with jackson-core-2.15.jar

Issues Resolved

Gradle version update to accommodate for opensearch-project/OpenSearch#7286 and referred to
FasterXML/jackson-core#955 (comment) and opensearch-project/sql#1584

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Monu Singh <msnghgw@amazon.com>
@monusingh-1 monusingh-1 marked this pull request as ready for review April 28, 2023 06:56
@monusingh-1 monusingh-1 requested a review from a team April 28, 2023 06:56
@monusingh-1 monusingh-1 enabled auto-merge (squash) April 28, 2023 06:57
@@ -11,6 +11,6 @@

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSearch is using 8.1.1: https://github.com/opensearch-project/OpenSearch/blob/2.x/gradle/wrapper/gradle-wrapper.properties
Shouldnt CCR be in sync with OpenSearch ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other incompatibilities in the build for Gradle 8, so 7.6.1 is the only option to keep a working build.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #815 (3642ee0) into 2.x (10e4449) will decrease coverage by 0.39%.
The diff coverage is n/a.

❗ Current head 3642ee0 differs from pull request most recent head d3c7fd1. Consider uploading reports for the commit d3c7fd1 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #815      +/-   ##
============================================
- Coverage     74.61%   74.22%   -0.39%     
+ Complexity     1017     1015       -2     
============================================
  Files           141      141              
  Lines          4633     4633              
  Branches        514      514              
============================================
- Hits           3457     3439      -18     
- Misses          852      867      +15     
- Partials        324      327       +3     

see 4 files with indirect coverage changes

@monusingh-1 monusingh-1 merged commit 794b6ec into opensearch-project:2.x Apr 28, 2023
saikaranam-amazon pushed a commit to saikaranam-amazon/cross-cluster-replication-2 that referenced this pull request May 31, 2023
Upgrade Gradle version to 7.6.1 to solve build failure with jackson-core-2.15.jar

Signed-off-by: Monu Singh <msnghgw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants