Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle Wrapper to 7.6.1 #1584

Closed
wants to merge 1 commit into from

Conversation

dbwiddis
Copy link
Member

Description

Gradle versions before 7.6 are incompatible with JDK 19 and later.

Some GitHub action backend code using jackson-core 2.5.0 is failing builds because it includes an MRJAR with JDK 19 code. See, for example, this failed action.

There are other incompatibilities in the build for Gradle 8, so 7.6.1 is the only option to keep a working build.

This commit is the result of executing ./gradlew wrapper.

Issues Resolved

N/A

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass, including unit test, integration test and doctest
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
    • [ ] New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1584 (d975c6f) into main (4522422) will increase coverage by 2.81%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1584      +/-   ##
============================================
+ Coverage     97.16%   99.98%   +2.81%     
+ Complexity     4116     2493    -1623     
============================================
  Files           371      193     -178     
  Lines         10365     5720    -4645     
  Branches        704      359     -345     
============================================
- Hits          10071     5719    -4352     
+ Misses          287        1     -286     
+ Partials          7        0       -7     
Flag Coverage Δ
sql-engine 99.98% <ø> (+2.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MaxKsyunz
Copy link
Collaborator

Thank you @dbwiddis !

@GumpacG has a PR (#1580 ) that updates Gradle and fixes build issues due to refactor in OpenSearch. It makes sense to combine the two.

@MaxKsyunz MaxKsyunz mentioned this pull request Apr 26, 2023
6 tasks
@dbwiddis
Copy link
Member Author

@GumpacG has a PR (#1580 ) that updates Gradle and fixes build issues due to refactor in OpenSearch. It makes sense to combine the two.

Yep, I didn't see that when I started the process, so it looks like we were both doing it at the same time.

For reference/clarity, simply updating the version in the properties (as #1580 does) is sufficient to get around the bug. Actually executing gradle wrapper also updates some of the supporting script/batch files and provides a local jar that eliminates the need to download it from gradle every time, saving a few seconds off build time.

@MaxKsyunz
Copy link
Collaborator

Closing this PR as this change is already in main.

@MaxKsyunz MaxKsyunz closed this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants