-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jackson from 2.14.2 to 2.15.0 #7286
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7286-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3168396208f849848f2cf0bf33a576a9c0e4d723
# Push it to GitHub
git push --set-upstream origin backport/backport-7286-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 3168396)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
By bumping jackson version, we will introduce the string length limitation, right? FasterXML/jackson-core#1001 (comment) NeuralSearch plugin team is working on some PoC with main branch (OpenSearch version: 3.0). They found the models saved in index can't be parsed correctly now. The model content saved as Base64 String in index. Any way for plugin team to tune the String limitation? |
That is correct
Not yet but looking into it |
@reta Any plan/ETA for supporting tuning String limitation? Can we support some cluster setting? So user can tune it if they need. |
Sorry about it, @ylwu-amzn, got sidetracked, do you have a test case to point out so we could see the problem, port it to OpenSearch and fix? ty |
@martin-gaievski Can you add more details here? |
@reta We do see this behavior in recent build of neural-search, in integ tests. Currently our CI is blocked by other issues and tests are not executed, but locally I'm able to run tests and I do see these errors:
Below are code refs to the code and model: |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Bump jackson from 2.14.2 to 2.15.0
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.