Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jackson from 2.14.2 to 2.15.0 #7286

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Apr 24, 2023

Description

Bump jackson from 2.14.2 to 2.15.0

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.pit.DeletePitMultiNodeIT.testDeleteWhileSearch
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

@reta reta merged commit 3168396 into opensearch-project:main Apr 25, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7286-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3168396208f849848f2cf0bf33a576a9c0e4d723
# Push it to GitHub
git push --set-upstream origin backport/backport-7286-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7286-to-2.x.

dblock pushed a commit that referenced this pull request Apr 25, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3168396)
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Apr 28, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@ylwu-amzn
Copy link
Contributor

By bumping jackson version, we will introduce the string length limitation, right? FasterXML/jackson-core#1001 (comment)

NeuralSearch plugin team is working on some PoC with main branch (OpenSearch version: 3.0). They found the models saved in index can't be parsed correctly now. The model content saved as Base64 String in index. Any way for plugin team to tune the String limitation?

@reta
Copy link
Collaborator Author

reta commented Apr 29, 2023

By bumping jackson version, we will introduce the string length limitation, right? FasterXML/jackson-core#1001 (comment)

That is correct

Any way for plugin team to tune the String limitation?

Not yet but looking into it

@ylwu-amzn
Copy link
Contributor

ylwu-amzn commented May 12, 2023

@reta Any plan/ETA for supporting tuning String limitation? Can we support some cluster setting? So user can tune it if they need.
This limitation blocks integration test of ML plugin

@reta
Copy link
Collaborator Author

reta commented May 12, 2023

This limitation blocks integration test of ML plugin

Sorry about it, @ylwu-amzn, got sidetracked, do you have a test case to point out so we could see the problem, port it to OpenSearch and fix? ty

@ylwu-amzn
Copy link
Contributor

@martin-gaievski Can you add more details here?

@martin-gaievski
Copy link
Member

martin-gaievski commented May 12, 2023

@reta We do see this behavior in recent build of neural-search, in integ tests. Currently our CI is blocked by other issues and tests are not executed, but locally I'm able to run tests and I do see these errors:

[2023-05-12T10:01:47,567][ERROR][o.o.m.m.MLModelManager   ] [integTest-0] Failed to parse ml taskubTpEIgBcDmbL-MBSJNu_0
com.fasterxml.jackson.core.exc.StreamConstraintsException: String length (5043368) exceeds the maximum length (5000000)
	at com.fasterxml.jackson.core.StreamReadConstraints.validateStringLength(StreamReadConstraints.java:290) ~[jackson-core-2.15.0.jar:2.15.0]
	at com.fasterxml.jackson.core.util.ReadConstrainedTextBuffer.validateStringLength(ReadConstrainedTextBuffer.java:27) ~[jackson-core-2.15.0.jar:2.15.0]
	at com.fasterxml.jackson.core.util.TextBuffer.finishCurrentSegment(TextBuffer.java:931) ~[jackson-core-2.15.0.jar:2.15.0]
	at com.fasterxml.jackson.core.json.UTF8StreamJsonParser._finishString2(UTF8StreamJsonParser.java:2584) ~[jackson-core-2.15.0.jar:2.15.0]
	at com.fasterxml.jackson.core.json.UTF8StreamJsonParser._finishAndReturnString(UTF8StreamJsonParser.java:2560) ~[jackson-core-2.15.0.jar:2.15.0]
	at com.fasterxml.jackson.core.json.UTF8StreamJsonParser.getText(UTF8StreamJsonParser.java:335) ~[jackson-core-2.15.0.jar:2.15.0]
	at org.opensearch.common.xcontent.json.JsonXContentParser.text(JsonXContentParser.java:96) ~[opensearch-x-content-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.ml.common.MLModel.parse(MLModel.java:345) ~[opensearch-ml-common-3.0.0.0-SNAPSHOT.jar:?]

Below are code refs to the code and model:
Test class https://github.com/martin-gaievski/neural-search/blob/bump-gradle-to-811/src/test/java/org/opensearch/neuralsearch/common/BaseNeuralSearchIT.java#L89
Model we're uploading: https://github.com/opensearch-project/ml-commons/blob/2.x/ml-algorithms/src/test/resources/org/opensearch/ml/engine/algorithms/text_embedding/traced_small_model.zip. It's the smallest pre-trained model we do have
Code the parses the model: https://github.com/opensearch-project/ml-commons/blob/main/common/src/main/java/org/opensearch/ml/common/MLModel.java#L304
Getting parser object from core: https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/main/java/org/opensearch/ml/utils/MLNodeUtils.java#L38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants