-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: icepyx: querying, obtaining, analyzing, and manipulating ICESat-2 datasets #4912
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Checking the BibTeX entries failed with the following error:
|
|
Wordcount for |
Review checklist for @VaasuDevanSConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋🏼 @JessicaS11 @dimejimudele, @VaasuDevanS this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks, or 4-6 weeks if needed. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@kthyng) if you have any questions/concerns. |
@JessicaS11 Have you put out your new release yet? Also, please address the bib issue above. |
Review checklist for @dimejimudeleConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Just a quick note: new icepyx version 0.6.4 has been released on 31 Oct 2022, see https://github.com/icesat2py/icepyx/releases/tag/v0.6.4
BibTeX should be fixed in icesat2py/icepyx@88e5116. |
Was causing issues with editorialbot at openjournals/joss-reviews#4912 (comment)
@editorialbot generate pdf |
Seems like the paper works now. |
Hi all! Just want to see how the review is going for everyone. Please let me know if you have any questions. |
Sure. @kthyng Thanks. |
@kthyng Should get through with this before the closing work for the year. Scheduled to work on this in the coming weekend. |
@kthyng Thanks for checking |
Just a question for @kthyng, I could not find paper.md in the joss branch of the project repository, but I have performed my review responsibilities so far using the pdf linked here. Any help? |
@dimejimudele The JOSS paper is in a branch called |
I have completed my review of this publication and the connected software tool. I should say it is an impressive project that has taken a lot of collaboration and time to deliver up to its current state. icepyx is a Python library for loading and processing ICESat-2 datasets. ICESat-2 is part of NASA's Earth Observing System and it provides data measuring ice sheet elevation and sea ice thickness, as well as land topography, vegetation characteristics, and clouds. This tool enables faster workflows in many scientific domains.
A minor clarification the authors might need to make is about the difference between icesat2py and icepyx. It appears to be the case that the former is a previous name for the latter. I do strongly recommend that this submission be published in JOSS. |
Thank you for your review @dimejimudele! |
Hello @kthyng! I have completed all five of the tasks in the author checklist (I am unable to check them off). |
@editorialbot set https://doi.org/10.5281/zenodo.7806097 as archive |
Done! Archive is now https://doi.org/10.5281/zenodo.7806097 |
@editorialbot set v0.6.4_JOSS as version |
Done! version is now v0.6.4_JOSS |
@JessicaS11 maybe I have to check off the list items? sorry for that confusion! |
@editorialbot check references |
|
List of paper comments:
|
Thanks @kthyng! Does JOSS have a recommended approach for applying these edits? I cannot update the files once they are on Zenodo (unless they agree to make an exception because I'm still within the one week window), and updating the repo won't port the changes over to Zenodo unless I create a new release (and thus change the release tag and and archive/DOI). Just want to make this as easy as possible for everyone! |
I'd say just update the paper and don't do anything else — it doesn't impact the software so isn't critical for the version nor archive to be exact for the paper wording. |
@editorialbot set pubs/joss as branch |
Done! branch is now pubs/joss |
@editorialbot generate pdf |
@kthyng Thanks for those edits - they should be all set! |
Great! We're all finished now. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats to @JessicaS11 on your new publication! Many thanks to reviewers @dimejimudele and @VaasuDevanS for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks to the reviewers and awesome editor @kthyng for all your hard work on this! |
Submitting author: @JessicaS11 (Jessica Scheick)
Repository: https://github.com/icesat2py/icepyx
Branch with paper.md (empty if default branch): pubs/joss
Version: v0.6.4_JOSS
Editor: @kthyng
Reviewers: @dimejimudele, @VaasuDevanS
Archive: https://doi.org/10.5281/zenodo.7806097
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dimejimudele & @VaasuDevanS, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kthyng know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @VaasuDevanS
📝 Checklist for @dimejimudele
The text was updated successfully, but these errors were encountered: