JOSS submission draft #361
Conversation
|
I will automatically update this comment whenever this PR is modified
|
There was a problem hiding this comment.
Thanks Jessica for putting this together!
Just wanted to know a bit about the author ordering, is this loosely based on the number of commits in https://github.com/icesat2py/icepyx/graphs/contributors or something? I just feel like surely other people have done a lot more work on icepyx than me, and my impostor syndrome is kicking in a bit 🙂
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Tyler Sutterley <tsutterl@uw.edu>
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## development #361 +/- ##
============================================
Coverage 59.09% 59.09%
============================================
Files 30 30
Lines 2264 2264
Branches 488 488
============================================
Hits 1338 1338
Misses 843 843
Partials 83 83 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
.github/workflows/draft-pdf.yml
Outdated
| # This is the output path where Pandoc will write the compiled | ||
| # PDF. Note, this should be the same directory as the input | ||
| # paper.md | ||
| path: doc/source/tracking/paper.pdf |
There was a problem hiding this comment.
GitHub Actions CI has been updated so the draft paper PDF is uploaded as an artifact. Get it by going to the 'Checks' tab at https://github.com/icesat2py/icepyx/pull/361/checks, then .github/workflows/draft-pdf.yml, and under 'Artifacts', there should be a paper link you can click to download a zipfile containing the PDF.
For example, the PDF for commit 45307de is at https://github.com/icesat2py/icepyx/actions/runs/2958374263
Add orcid for Zheng Liu. Changed the name of affiliation #4 to University of Washington instead of the generic "Institution" to be consistent with all other UW authors.
doc/source/tracking/paper.md
Outdated
| The instruments provide close to 500 GB of data per day, allowing scientists to investigate the surface height of earth's features in unprecedented detail. | ||
|
|
||
| icepyx began during the cryosphere-themed ICESat-2 Hackweek at the University of Washington in June 2019. | ||
| At the event, a clear need for a collaborative, shared community space that combined and generalized the tooling (including code and examples past, present, and future) written by Hackweek participants, ICESat-2 Science Team members, and the data user community. |
There was a problem hiding this comment.
My 2c is I like the 'past, present, future' language as it's simple adn conveys the message well. I like what @weiji14 worked up here
doc/source/tracking/paper.md
Outdated
| The instruments provide close to 500 GB of data per day, allowing scientists to investigate the surface height of earth's features in unprecedented detail. | ||
|
|
||
| icepyx began during the cryosphere-themed ICESat-2 Hackweek at the University of Washington in June 2019. | ||
| At the event, a clear need for a collaborative, shared community space that combined and generalized the tooling (including code and examples past, present, and future) written by Hackweek participants, ICESat-2 Science Team members, and the data user community. |
There was a problem hiding this comment.
could also say 'At the event, there was a clear need for a collaborative, shared community space that UNIFIED and generalized the tools and material written by past, present, and future Hackweek participants, ICESat-2 Science Team members, and the data user community.
Was causing issues with editorialbot at openjournals/joss-reviews#4912 (comment)
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
added ORCID for Romina Piunno
We're working on a submission to JOSS. Please post your submission comments here!
JOSS submission at openjournals/joss-reviews#4820
Review at openjournals/joss-reviews#4912