EWPP-873: Text with featured media paragraph type V2 #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[EWPP-873] EWPP-876: Theme the link and new variants on text with featued media paragraphs.
[EWPP-873] EWPP-1327: Theme text with featured media title.
…ia-2 EWPP-873: Update epic branch.
…o changes in oe_paragraph component.
[EWPP-873] EWPP-1318: Port new "Featured media with text" pattern to ECL v3.
…ia-2-20210804 Merge 3.x into EPIC EWPP-874 Text with featured media v2
EWPP-1209: Ensure that Link field exist.
…ia-2-20210907 Update epic ewpp 873 text media 2
ademarco
requested changes
Sep 8, 2021
| /** | ||
| * Update default view display for Text with featured media paragraph. | ||
| */ | ||
| function oe_theme_helper_post_update_20017() { |
There was a problem hiding this comment.
This is now ran by oe_paragraphs, we should remove it from here. Same goes for the configuration file itself.
| $link_field = $paragraph->get('field_oe_link')->first(); | ||
| $variables['link'] = [ | ||
| 'path' => $link_field->getUrl()->toString(), | ||
| 'label' => $link_field->get('title')->getValue(), |
There was a problem hiding this comment.
Is link field cache properly bubbled here?
EWPP-873: Align epic with 3.x
EWPP-873: Add cache info from the Link field to the page.
…ia-2-20210917 Update epic ewpp 873 text media 2 20210917
sergepavle
previously approved these changes
Sep 17, 2021
…ia-2-20210917-2 Update epic ewpp 873 text media 2 20210917 2
upchuk
approved these changes
Sep 17, 2021
ademarco
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.