-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EWPP-873] EWPP-876: Theme the link and new variants on text with featued media paragraphs. #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyad
requested changes
Jun 14, 2021
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
22Alexandra
requested changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests need to be fixed.
yenyasinn
force-pushed
the
EWPP-876
branch
3 times, most recently
from
June 15, 2021 15:34
050a50f
to
e47b8e9
Compare
22Alexandra
previously approved these changes
Jun 16, 2021
yenyasinn
changed the title
EWPP-876: Theme the link and new variants on text with featued media paragraphs.
[EWPP-873] EWPP-876: Theme the link and new variants on text with featued media paragraphs.
Jun 22, 2021
imanoleguskiza
suggested changes
Jun 24, 2021
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
templates/patterns/text_featured_media/text_featured_media.ui_patterns.yml
Outdated
Show resolved
Hide resolved
imanoleguskiza
previously approved these changes
Jul 7, 2021
imanoleguskiza
previously approved these changes
Jul 7, 2021
nagyad
previously approved these changes
Jul 7, 2021
imanoleguskiza
dismissed stale reviews from nagyad and themself
July 8, 2021 08:42
The base branch was changed.
nagyad
approved these changes
Jul 8, 2021
imanoleguskiza
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.