Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EWPP-873] EWPP-1327: Theme text with featured media title. #878

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

yenyasinn
Copy link
Contributor

No description provided.

@yenyasinn yenyasinn changed the title EWPP-1327: Theme text with featured media title. [EWPP-873] EWPP-1327: Theme text with featured media title. Jul 15, 2021
@@ -15,6 +15,7 @@
{{ pattern('text_featured_media', {
'variant': variant,
'title': not paragraph.field_oe_title.isEmpty ? content.field_oe_title,
'text_title': not paragraph.field_oe_feature_media_title.isEmpty ? content.field_oe_feature_media_title,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on update path because core.entity_view_display.paragraph.oe_text_feature_media.default.yml only has the field_oe_feature_media_title enabled on the install path.

Copy link
Contributor

@22Alexandra 22Alexandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the view display to include the new title field.

@imanoleguskiza imanoleguskiza merged commit d42470e into EPIC-EWPP-873-Text-media-2 Jul 22, 2021
@brummbar brummbar deleted the EWPP-1327 branch January 31, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants