Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: change ossm sidecar as labels on authornio deployment #1702

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Feb 27, 2025

  • change annotations to labels when we do patch on authornio deployment

Description

rewrite of #1513

https://issues.redhat.com/browse/RHOAIENG-18238

How Has This Been Tested?

local build quay.io/wenzhou/opendatahub-operator:2.26.18238

  • install operator
  • install authornio servicemesh operator
  • create DSCI with servicemesh Managed
  • check authorino-XXX pod in opendatahub-auth-provider ns has 2 contains, one is istio-proxy

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- as a soft handover, to keep annotation for now, just add new one
- we will need to remove the annotation one later as cleanup

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci bot requested review from biswassri and etirelli February 27, 2025 13:25
@zdtsw zdtsw requested review from dhirajsb, bartoszmajsak, lphiri and israel-hdez and removed request for etirelli and biswassri February 27, 2025 13:27
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.01%. Comparing base (73d70b8) to head (897b6eb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
controllers/dscinitialization/servicemesh_setup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1702      +/-   ##
==========================================
- Coverage   22.18%   22.01%   -0.18%     
==========================================
  Files         168      168              
  Lines       11384    11359      -25     
==========================================
- Hits         2526     2501      -25     
- Misses       8600     8601       +1     
+ Partials      258      257       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw changed the title update: add ossm sidecar as labels on authornio deployment update: change ossm sidecar as labels on authornio deployment Feb 27, 2025
@lphiri
Copy link

lphiri commented Feb 27, 2025

/lgtm

Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lphiri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7eeb024 into opendatahub-io:main Feb 27, 2025
10 checks passed
robotmaxtron pushed a commit to robotmaxtron/opendatahub-operator that referenced this pull request Feb 28, 2025
…tahub-io#1702)

* update: add ossm sidecar as labels on authornio deployment

- as a soft handover, to keep annotation for now, just add new one
- we will need to remove the annotation one later as cleanup

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* update: remove annotations

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants