Skip to content

Commit

Permalink
update: change ossm sidecar as labels on authornio deployment (#1702)
Browse files Browse the repository at this point in the history
* update: add ossm sidecar as labels on authornio deployment

- as a soft handover, to keep annotation for now, just add new one
- we will need to remove the annotation one later as cleanup

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* update: remove annotations

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
  • Loading branch information
zdtsw authored Feb 27, 2025
1 parent 2fa3afc commit 7eeb024
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ metadata:
spec:
template:
metadata:
annotations:
labels:
sidecar.istio.io/inject: "true"
2 changes: 1 addition & 1 deletion controllers/dscinitialization/servicemesh_setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (r *DSCInitializationReconciler) authorizationFeatures(instance *dsciv1.DSC

// We do not have the control over deployment resource creation.
// It is created by Authorino operator using Authorino CR and labels are not propagated from Authorino CR to spec.template
// See https://issues.redhat.com/browse/RHOAIENG-5494
// See https://issues.redhat.com/browse/RHOAIENG-5494 and https://github.com/Kuadrant/authorino-operator/pull/243
//
// To make it part of Service Mesh we have to patch it with injection
// enabled instead, otherwise it will not have proxy pod injected.
Expand Down

0 comments on commit 7eeb024

Please sign in to comment.