Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: change ossm sidecar as labels on authornio deployment #1702

Merged
merged 2 commits into from
Feb 27, 2025
+2 −2
Merged

update: change ossm sidecar as labels on authornio deployment #1702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4600cf5
update: add ossm sidecar as labels on authornio deployment
zdtsw Feb 27, 2025
897b6eb
update: remove annotations
zdtsw Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions controllers/dscinitialization/resources/authorino/deployment.injection.patch.tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ metadata:
spec:
template:
metadata:
labels:
sidecar.istio.io/inject: "true"
annotations:
sidecar.istio.io/inject: "true"
2 changes: 1 addition & 1 deletion controllers/dscinitialization/servicemesh_setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@

// We do not have the control over deployment resource creation.
// It is created by Authorino operator using Authorino CR and labels are not propagated from Authorino CR to spec.template
// See https://issues.redhat.com/browse/RHOAIENG-5494
// See https://issues.redhat.com/browse/RHOAIENG-5494 and https://github.com/Kuadrant/authorino-operator/pull/243

Check warning on line 212 in controllers/dscinitialization/servicemesh_setup.go

View check run for this annotation

Codecov / codecov/patch

controllers/dscinitialization/servicemesh_setup.go#L212 

Added line #L212 was not covered by tests
//
// To make it part of Service Mesh we have to patch it with injection
// enabled instead, otherwise it will not have proxy pod injected.
Expand Down