Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with main for ODH 2.20 #278

Closed
wants to merge 18 commits into from
Closed

Sync with main for ODH 2.20 #278

wants to merge 18 commits into from

Conversation

hdefazio
Copy link
Contributor

Sync with main

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

mholder6 and others added 18 commits July 19, 2024 11:08
Signed-off-by: mholder6 <marholde@redhat.com>
Signed-off-by: root <root@m13lp70.lnxero1.boe>
Signed-off-by: Killian Golds <kgolds@redhat.com>
Update ENVTEST_K8S_VERSION for s390x
…pgrade

Updated kustomize labels to kustomize v5 syntax
[RHOAIENG-9411] - Update odh-model-controller's istio dependencies to 1.21
In created AuthConfigs, instead of checking for GET over Kubernetes Services, do a more fine-grained check over InferenceServices: test that the user can GET the specific InferenceServices. This will allow protecting models individually.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
…in Kserve Performance metrics (#256)

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com>
…stants to instead be fetched by env vars. (#254)

Signed-off-by: mholder6 <marholde@redhat.com>
it's the default

Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
…h-model-controller (#263)

Signed-off-by: Spolti <fspolti@redhat.com>
… field (#264)

chore:	fix nil pointer if the custom isvc does not have the model field.

Signed-off-by: Spolti <fspolti@redhat.com>
* Enabled CI to provide additional support for s390x and power

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

* Modified Quay Access token to Password for consistency

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

* runtimes: remove distributed executor backend option from vllm (#257)

it's the default

Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

* [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (#263)

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

* Modified the tag to vX.Y.Z-latest format

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

---------

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
Signed-off-by: Spolti <fspolti@redhat.com>
Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com>
Co-authored-by: Filippe Spolti <fspolti@redhat.com>
…ead of 3 (#268)

Signed-off-by: mholder6 <marholde@redhat.com>
Signed-off-by: rpancham <rpancham@redhat.com>
…ers. (#275)

Signed-off-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb>
Co-authored-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb>
Signed-off-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb>
Co-authored-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb>
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hdefazio
Once this PR has been reviewed and has the lgtm label, please assign rpancham for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@hdefazio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images a404606 link true /test images
ci/prow/unit a404606 link true /test unit
ci/prow/pr-image-mirror a404606 link true /test pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hdefazio
Copy link
Contributor Author

Closing in favor of #279

@hdefazio hdefazio closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.