Multi-arch Build support #262

Nash-123 · 2024-08-30T10:03:51Z

Created a github workflow to build & publish multi-arch image .
Tested locally & find the snapshot below .
Please ensure that the following secrets are created in the repository settings. These secrets are required for authentication with the Quay registry:

QUAY_USERNAME: The username for Quay registry authentication.
QUAY_PASSWORD: The password for Quay registry authentication.
@israel-hdez , please help to review the changes and provide feedback

openshift-ci · 2024-08-30T10:04:02Z

Hi @Nash-123. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

modassarrana89 · 2024-09-03T09:06:33Z

@israel-hdez As discussed , we have created github workflow for multi-arch image build for latest & release tag. Please review

Nash-123 · 2024-09-06T06:09:08Z

Hi @israel-hdez / @VedantMahabaleshwarkar , can you please help to review the PR, we have created github workflow for multi-arch image(arm64,amd64,power,s390x) build for latest and release tag

israel-hdez · 2024-09-09T23:52:07Z

.github/workflows/build.yaml

+        with:
+          registry: quay.io
+          username: ${{ secrets.QUAY_USER }}
+          password: ${{ secrets.QUAY_ACCESS_TOKEN }}


In our other repos, we are using QUAY_PASSWORD rather than access token (example).

May you replace QUAY_ACCESS_TOKEN with QUAY_PASSWORD for consistency?

@Nash-123 Please address this change

@israel-hdez I've replaced QUAY_ACCESS_TOKEN with QUAY_PASSWORD and have updated the PR description to include instructions for creating the secret. Please review and let us know if there are any further changes needed.

israel-hdez · 2024-09-09T23:58:13Z

.github/workflows/build.yaml

+            echo "TAG=latest" >> $GITHUB_ENV
+          elif [[ "${GITHUB_REF}" == refs/heads/release-* ]]; then
+            VERSION="${GITHUB_REF#refs/heads/release-}"
+            echo "TAG=v${VERSION}" >> $GITHUB_ENV


are you happy with vX.Y.Z? or would you rather vX.Y.Z-latest?

@israel-hdez We have stick to 2 different type of tags i.e. currently available for x86 on quay repository

Release Tag ( v0.11.0)

latest

Please suggest how did you want us to handle it. Should we stick to the same naming convention for tag or the one which you have suggested in comments ie vX.Y.Z-latest

I was checking our prow/tide configs and it's using the vX.Y.Z tags. So, it is a conflict and this workflow and prow/tide can overwrite the other image, depending on which one push at last.

It will be better to use a -latest suffix, or some other suffix to prevent the conflict.

Hi @israel-hdez, we've made the changes as requested to add a suffix to the tag (vX.Y.Z-latest). Please help to review.

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

…atahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

…h-model-controller (opendatahub-io#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

…rch_support

israel-hdez · 2024-09-12T20:25:16Z

/ok-to-test

@Nash-123 @modassarrana89 Let me configure the secrets in the repo (there are no secrets) on my Friday and I'll merge after that. If this new workflow would run, images would be built and we can check that it works.

israel-hdez

/lgtm

openshift-ci · 2024-09-13T22:49:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Nash-123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [israel-hdez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

israel-hdez · 2024-09-13T23:13:51Z

It failed... the credentials I had on my records are outdated. I'll figure out the new credentials.

Nash-123 · 2024-09-15T16:38:25Z

Surely @israel-hdez . Thanks !!

israel-hdez · 2024-09-18T19:03:49Z

@Nash-123 it is all set now:

rareddy · 2024-09-20T13:18:58Z

@dhirajsb @isinyaaa anything we can learn from here?

* Enabled CI to provide additional support for s390x and power Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified Quay Access token to Password for consistency Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * runtimes: remove distributed executor backend option from vllm (opendatahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (opendatahub-io#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified the tag to vX.Y.Z-latest format Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com>

* Enabled CI to provide additional support for s390x and power Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified Quay Access token to Password for consistency Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * runtimes: remove distributed executor backend option from vllm (opendatahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (opendatahub-io#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified the tag to vX.Y.Z-latest format Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com>

* Multi-arch Build support (#262) * Enabled CI to provide additional support for s390x and power Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified Quay Access token to Password for consistency Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * runtimes: remove distributed executor backend option from vllm (#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified the tag to vX.Y.Z-latest format Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com> * Updated manifests to have 1 replica of odh-model-controller pods instead of 3 (#268) Signed-off-by: mholder6 <marholde@redhat.com> * Sync with main branch Signed-off-by: mholder6 <marholde@redhat.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com> Co-authored-by: Nishan Acharya <58680481+Nash-123@users.noreply.github.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com>

Update caikit-tgis and ovms for 2.16.1

openshift-ci bot requested review from israel-hdez and VedantMahabaleshwarkar August 30, 2024 10:03

openshift-ci bot added the needs-ok-to-test label Aug 30, 2024

Nash-123 force-pushed the multi_arch_support branch from 2040072 to 0518694 Compare August 30, 2024 10:41

israel-hdez reviewed Sep 9, 2024

View reviewed changes

Nash-123 and others added 4 commits September 10, 2024 09:29

Enabled CI to provide additional support for s390x and power

e3add6d

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

Modified Quay Access token to Password for consistency

5dc2df0

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

runtimes: remove distributed executor backend option from vllm (opend…

ffc259c

…atahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

[RHOAIENG-9746] - Missing log entry in StorageConfig controller of od…

c7527d6

…h-model-controller (opendatahub-io#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

Nash-123 force-pushed the multi_arch_support branch from 2afc689 to c7527d6 Compare September 10, 2024 07:30

Nash-123 and others added 3 commits September 10, 2024 13:02

Merge branch 'opendatahub-io:main' into multi_arch_support

b88c4fd

Modified the tag to vX.Y.Z-latest format

1d46c21

Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>

Merge remote-tracking branch 'origin/multi_arch_support' into multi_a…

a370cd9

…rch_support

openshift-ci bot added ok-to-test and removed needs-ok-to-test labels Sep 12, 2024

israel-hdez approved these changes Sep 13, 2024

View reviewed changes

openshift-ci bot assigned israel-hdez Sep 13, 2024

openshift-ci bot added the lgtm label Sep 13, 2024

openshift-ci bot added the approved label Sep 13, 2024

openshift-merge-bot bot merged commit 0af4425 into opendatahub-io:main Sep 13, 2024
3 checks passed

spolti pushed a commit to spolti/odh-model-controller that referenced this pull request Jan 20, 2025

Merge pull request opendatahub-io#262 from heyselbi/rhoai-216

9dd9419

Update caikit-tgis and ovms for 2.16.1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi-arch Build support #262

Multi-arch Build support #262

Nash-123 commented Aug 30, 2024 •

edited

Loading

openshift-ci bot commented Aug 30, 2024

modassarrana89 commented Sep 3, 2024

Nash-123 commented Sep 6, 2024

israel-hdez Sep 9, 2024

modassarrana89 Sep 10, 2024

Nash-123 Sep 10, 2024

israel-hdez Sep 9, 2024

modassarrana89 Sep 10, 2024

israel-hdez Sep 11, 2024

modassarrana89 Sep 11, 2024

Nash-123 Sep 11, 2024

israel-hdez commented Sep 12, 2024

israel-hdez left a comment

openshift-ci bot commented Sep 13, 2024

israel-hdez commented Sep 13, 2024

Nash-123 commented Sep 15, 2024

israel-hdez commented Sep 18, 2024

rareddy commented Sep 20, 2024

Multi-arch Build support #262

Multi-arch Build support #262

Conversation

Nash-123 commented Aug 30, 2024 • edited Loading

openshift-ci bot commented Aug 30, 2024

modassarrana89 commented Sep 3, 2024

Nash-123 commented Sep 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

israel-hdez commented Sep 12, 2024

israel-hdez left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 13, 2024

israel-hdez commented Sep 13, 2024

Nash-123 commented Sep 15, 2024

israel-hdez commented Sep 18, 2024

rareddy commented Sep 20, 2024

Nash-123 commented Aug 30, 2024 •

edited

Loading