runtimes: remove distributed executor backend option from vllm #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
update-vllm-command-line-argments
branch
from
f062356 to
1f0c13b
Compare
it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
|
@dtrifiro May you either mention the ticket/jira, or have somebody else from runtimes to approve this? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro, NickLucche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Nash-123
pushed a commit
to Nash-123/odh-model-controller
that referenced
this pull request
Sep 10, 2024
…atahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com>
VedantMahabaleshwarkar
pushed a commit
to VedantMahabaleshwarkar/odh-model-controller
that referenced
this pull request
Sep 13, 2024
…atahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
VedantMahabaleshwarkar
added a commit
that referenced
this pull request
Sep 13, 2024
* chore: ensure functions use inherited context (#251) Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Removed and replaced the IstioControlPlaneName and IstioNamespace constants to instead be fetched by env vars. (#254) Signed-off-by: mholder6 <marholde@redhat.com> * runtimes: remove distributed executor backend option from vllm (#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (#263) Signed-off-by: Spolti <fspolti@redhat.com> * [RHOAIENG-12726] - odh-model-controller crashes with empty isvc.model field (#264) chore: fix nil pointer if the custom isvc does not have the model field. Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: mholder6 <marholde@redhat.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Co-authored-by: Mariah Holder <94134625+mholder6@users.noreply.github.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Enabled CI to provide additional support for s390x and power Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified Quay Access token to Password for consistency Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * runtimes: remove distributed executor backend option from vllm (#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified the tag to vX.Y.Z-latest format Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com>
mholder6
pushed a commit
to mholder6/odh-model-controller
that referenced
this pull request
Oct 4, 2024
* Enabled CI to provide additional support for s390x and power Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified Quay Access token to Password for consistency Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * runtimes: remove distributed executor backend option from vllm (opendatahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (opendatahub-io#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified the tag to vX.Y.Z-latest format Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com>
mholder6
pushed a commit
to mholder6/odh-model-controller
that referenced
this pull request
Oct 4, 2024
* Enabled CI to provide additional support for s390x and power Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified Quay Access token to Password for consistency Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * runtimes: remove distributed executor backend option from vllm (opendatahub-io#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (opendatahub-io#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified the tag to vX.Y.Z-latest format Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Multi-arch Build support (#262) * Enabled CI to provide additional support for s390x and power Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified Quay Access token to Password for consistency Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * runtimes: remove distributed executor backend option from vllm (#257) it's the default Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * [RHOAIENG-9746] - Missing log entry in StorageConfig controller of odh-model-controller (#263) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> * Modified the tag to vX.Y.Z-latest format Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com> * Updated manifests to have 1 replica of odh-model-controller pods instead of 3 (#268) Signed-off-by: mholder6 <marholde@redhat.com> * Sync with main branch Signed-off-by: mholder6 <marholde@redhat.com> --------- Signed-off-by: Nishan Acharya IBM <mamabapuni@gmail.com> Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com> Co-authored-by: Nishan Acharya <58680481+Nash-123@users.noreply.github.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com> Co-authored-by: Filippe Spolti <fspolti@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's the default