SER Support #1979
Closed
SER Support #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
reviewed
Mar 7, 2024
inc/saitypes.h
Outdated
| typedef union _sai_health_data_t | ||
| { | ||
| /** @validonly data_type == SAI_HEALTH_DATA_TYPE_SER */ | ||
| sai_ser_health_data_t ser; |
There was a problem hiding this comment.
Why there is only one field where? Dont create stricte with one wntry
There was a problem hiding this comment.
This is the original design discussed in 1777 so seems good
Per health event we create a struct
Each health event is only of one type at a time, so we use a union
So let's say we have 2 types of event
struct health_a_data
struct health_b_data
we will put in the union
union health_data {a_data, b_data}
|
Fix build errors |
…ct#1934) Signed-off-by: Mike Beresford <mberes@google.com> Add a MAC remote loopback type to sai_port_loopback_mode_t. This is the MAC-layer equivalent of SAI_PORT_LOOPBACK_MODE_PHY_REMOTE
* Add atrributes to disable L3 rewrites - Src MAC disable - Dst MAC disable - Vlan rewrite disable Signed-off-by: Vivek Ramamoorthy <vivekmoorthy@google.com> Knobs for disabling rewrites to following fields Src MAC disable Dst MAC disable Vlan rewrite disable While we do L3 IP based routing, we have scenarios where we need knobs for disabling L2 field rewrites. Case 1: For some scenarios, the switch serves as an L3 passthrough. Creating nexthop/RIF for every source mac, dst-mac, vlan will not scale, and we would like to simply passthrough the L2 fields without any rewrites Case 2: For some scenarios, we set VLAN in pre-ingress stage based on certain classification, and would like to preserve this VLAN in the packet.
Cable diagnostics is required when the characteristics of the problems associated with a cable become of paramount concern when a link cannot be established or is performing poorly. Enhanced Cable Diagnostics (ECD) provides with intelligent pre-processing and post-processing algorithm inside HW that can be initiated at any time by setting specific register bits and then reading the results. Signed-off-by: Prafull Singh <56103377+prafull-brcm@users.noreply.github.com>
To make sure all custom ranges are beginning from the same value
Will be required for DASH port stat extensions Co-authored-by: r12f <r12f.code@gmail.com>
…uteproject#1949) We discovered that in ProcessStructValueType, as a member of a struct, the types sai_uint8_t, uint32_t, and uint64_t are permitted, but uint16_t is not. Since we plan to incorporate flow API into DASH and require src_port and dst_port to be uint16_t, we are including uint16_t in ProcessStructValueType to address this. Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
…t#1946) In Bookworm, the LATEX_SOURCE_CODE and CLASS_DIAGRAMS options are deprecated/removed. Comment these options out in the Doxyfile. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: mssonicbld <sonicbld@microsoft.com> Co-authored-by: mssonicbld <sonicbld@microsoft.com>
The word ENI is a term which means elastic network interface. It is used in DASH project and its API design, hence adding this word into the aspell checker. This issue didn't show up before very likely because aspell ignores the code, however, once we use it in comments, it starts to fail.
Added SAI_ACL_ENTRY_ATTR_FIELD_VRF_ID and SAI_ACL_ENTRY_ATTR_FIELD_IPMC_NPU_META_DST_HIT Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
…teproject#1966) This change adds the SAI API changes for enabling the load balancer fast path scenario. DASH load balancer fast path HLD: https://github.com/sonic-net/DASH/blob/main/documentation/load-bal-service/fast-path-icmp-flow-redirection.md Change that used to generate the headers: [dash-p4] Update DASH BM P4 code for fast path SAI API generation sonic-net/DASH#517 Signed-off-by: r12f <r12f.code@gmail.com>
This specification suggests: The idea of an ICMP echo object or session that can be transferred to HW/ASIC or other modules for faster link detection. The introduction of SAI APIs to outline ICMP echo session properties. The introduction of a switch-level notification API to monitor changes in ICMP echo session states.
As planned as of end of 2023 this directory is being depreacated
saithrift package is getting installed at different location for bookworm. Taking care it using copy_installer.sh script. This change fixes build issue for both saithriftv1 and saithriftv2 Signed-off-by: Keshav Gupta <keshavg@marvell.com>
This reverts commit 2de4740.
This reverts commit 07089c9.
Closed
|
Opened a new PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SER Support is added on top of base infra introduced by
#1777