Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAI_ACL_ENTRY_ATTR_FIELD_VRF_ID and SAI_ACL_ENTRY_ATTR_FIELD_IPMC_NPU_META_DST_HIT match qualifiers for acl table #1952

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mholankar
Copy link
Contributor

Added SAI_ACL_ENTRY_ATTR_FIELD_VRF_ID and SAI_ACL_ENTRY_ATTR_FIELD_IPMC_NPU_META_DST_HIT

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 30, 2024

Please fix build issues

Added SAI_ACL_ENTRY_ATTR_FIELD_VRF_ID and SAI_ACL_ENTRY_ATTR_FIELD_IPMC_NPU_META_DST_HIT

Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
@mholankar
Copy link
Contributor Author

@mikeberesford

@mholankar
Copy link
Contributor Author

@kcudnik could you please help merge this?

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 31, 2024

was this discussed on SAI community meeting ?

@mholankar
Copy link
Contributor Author

No not yet. I will discuss in tomorrow's meeting.

Copy link
Contributor

@JaiOCP JaiOCP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mholankar
Copy link
Contributor Author

@kcudnik could you please help me merge this? This PR got approved in today's SAI meeting.

@kcudnik kcudnik merged commit 2c7c726 into opencomputeproject:master Feb 16, 2024
3 checks passed
JaiOCP pushed a commit to JaiOCP/SAI that referenced this pull request Mar 7, 2024
Added SAI_ACL_ENTRY_ATTR_FIELD_VRF_ID and SAI_ACL_ENTRY_ATTR_FIELD_IPMC_NPU_META_DST_HIT

Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
@mholankar mholankar deleted the manaliFpVrfQ branch July 3, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants