[dash-p4] Update DASH BM P4 code for fast path SAI API generation #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
working in progress just in case anyone is interested in preview, will convert it back to PR once it is ready for review. |
|
ok, I think it is ready for review now. There are some minor naming changes following what we are doing currently in DASH, so I updated the HLD to make them align. |
kcudnik
approved these changes
Feb 15, 2024
marian-pritsak
approved these changes
Feb 15, 2024
|
Thanks Marian! I will submit the SAI header update PR as well today. |
rlhui
pushed a commit
to opencomputeproject/SAI
that referenced
this pull request
Feb 29, 2024
This change adds the SAI API changes for enabling the load balancer fast path scenario. DASH load balancer fast path HLD: https://github.com/sonic-net/DASH/blob/main/documentation/load-bal-service/fast-path-icmp-flow-redirection.md Change that used to generate the headers: [dash-p4] Update DASH BM P4 code for fast path SAI API generation sonic-net/DASH#517 Signed-off-by: r12f <r12f.code@gmail.com>
JaiOCP
pushed a commit
to JaiOCP/SAI
that referenced
this pull request
Mar 7, 2024
…teproject#1966) This change adds the SAI API changes for enabling the load balancer fast path scenario. DASH load balancer fast path HLD: https://github.com/sonic-net/DASH/blob/main/documentation/load-bal-service/fast-path-icmp-flow-redirection.md Change that used to generate the headers: [dash-p4] Update DASH BM P4 code for fast path SAI API generation sonic-net/DASH#517 Signed-off-by: r12f <r12f.code@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to support generating the load balancer fast path SAI APIs. It follows the HLD in the doc repo: https://github.com/sonic-net/DASH/blob/main/documentation/load-bal-service/fast-path-icmp-flow-redirection.md.
This change doesn't really contains any real behavior for parsing fast path packets and etc. These updates will come later time.
The updated SAI headers can be previewed here: r12f/SAI@d0e2904