Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cloud.zone to cloud.availability_zone #1495

Merged
merged 7 commits into from
Mar 11, 2021
Merged

Rename cloud.zone to cloud.availability_zone #1495

merged 7 commits into from
Mar 11, 2021

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Mar 3, 2021

Only Google Cloud calls availability zones a zone. Renaming zone
to make the least common case an exception.

This change is a follow-up of #1481.

@rakyll rakyll requested review from a team March 3, 2021 01:02
reyang
reyang approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's like a political game, but your statement "only Google calls..." makes sense to me.
More importantly, I think availability zone is just a better term than "zone" since it is more specific.

Oberon00
Oberon00 approved these changes Mar 3, 2021
View reviewed changes
semantic_conventions/resource/cloud.yaml Outdated Show resolved Hide resolved
arminru
arminru approved these changes Mar 3, 2021
View reviewed changes
semantic_conventions/resource/cloud.yaml Outdated Show resolved Hide resolved
@rakyll
Copy link
Contributor Author

rakyll commented Mar 3, 2021

PTAL

@carlosalberto carlosalberto mentioned this pull request Mar 5, 2021
Open
rakyll and others added 5 commits March 10, 2021 10:24
@rakyll
Rename cloud.zone to cloud.availability_zone
80ba661 
Only Google Cloud calls availability zones a zone. Renaming zone
to make the least common case an exception.

This change is a follow-up of #1481.
@rakyll
Add link to the CHANGELOG
f9ad216
@rakyll @Oberon00
Update semantic_conventions/resource/cloud.yaml
dac0a21 
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
@rakyll @arminru
Update semantic_conventions/resource/cloud.yaml
458d733 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@rakyll
Regenerate
df116ee
@rakyll
Copy link
Contributor Author

rakyll commented Mar 10, 2021

We discussed in the meeting and decided that readability matters more. We always have a way to compress the keys in the future on the wire and at rest if it's needed. This change should be good to be merged.

I will also send a change with recommendations on max key lengths as a guideline as we discussed earlier.

@rakyll
Copy link
Contributor Author

rakyll commented Mar 10, 2021

@Oberon00 @iNikem @arminru @reyang Can we merge this change?

@arminru arminru merged commit de91241 into open-telemetry:main Mar 11, 2021
jrcamp added a commit to jrcamp/opentelemetry-collector that referenced this pull request Mar 25, 2021
@jrcamp
Updates for cloud semantic conventions
27cd9eb 
cloud.infrastructure_service -> cloud.platform
cloud.zone -> cloud.availability_zone

These changes were made in:

open-telemetry/opentelemetry-specification#1495
open-telemetry/opentelemetry-specification#1530

Will make changes in contrib next.
@jrcamp jrcamp mentioned this pull request Mar 25, 2021
Merged
jrcamp added a commit to jrcamp/opentelemetry-collector that referenced this pull request Mar 25, 2021
@jrcamp
Updates for cloud semantic conventions
b132f30 
cloud.infrastructure_service -> cloud.platform
cloud.zone -> cloud.availability_zone

These changes were made in:

open-telemetry/opentelemetry-specification#1495
open-telemetry/opentelemetry-specification#1530

Will make changes in contrib next.
jrcamp added a commit to jrcamp/opentelemetry-collector that referenced this pull request Mar 25, 2021
@jrcamp
Updates for cloud semantic conventions
0e48800 
cloud.infrastructure_service -> cloud.platform
cloud.zone -> cloud.availability_zone

These changes were made in:

open-telemetry/opentelemetry-specification#1495
open-telemetry/opentelemetry-specification#1530

Will make changes in contrib next.
bogdandrutu pushed a commit to open-telemetry/opentelemetry-collector that referenced this pull request Mar 25, 2021
@jrcamp
Updates for cloud semantic conventions (#2809)
d8e9970 
* Updates for cloud semantic conventions

cloud.infrastructure_service -> cloud.platform
cloud.zone -> cloud.availability_zone

These changes were made in:

open-telemetry/opentelemetry-specification#1495
open-telemetry/opentelemetry-specification#1530

Will make changes in contrib next.

* fix oc conversion
ThomsonTan pushed a commit to ThomsonTan/opentelemetry-specification that referenced this pull request Mar 30, 2021
@rakyll @Oberon00
@arminru @ThomsonTan
Rename cloud.zone to cloud.availability_zone (open-telemetry#1495)
420de0e 
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@fbogsany fbogsany mentioned this pull request Apr 30, 2021
Merged
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@rakyll @Oberon00 @arminru
Rename cloud.zone to cloud.availability_zone (open-telemetry#1495)
7cbca0a 
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro left review comments

@bogdandrutu bogdandrutu bogdandrutu left review comments

@Oberon00 Oberon00 Oberon00 approved these changes

@carlosalberto carlosalberto carlosalberto left review comments

@jsuereth jsuereth jsuereth left review comments

@reyang reyang reyang approved these changes

@arminru arminru arminru approved these changes

@iNikem iNikem iNikem approved these changes

@alolita alolita alolita approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.