Clarify the cloud resource attributes #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide better examples representing account IDs, regions and zones from non-GCP providers. Improve the description to explain the relationship between resource and cloud attributes: The resource is created or running in the account, region and zones.
arminru
added
area:semantic-conventions
Oberon00
approved these changes
Mar 1, 2021
| @@ -23,20 +23,26 @@ groups: | |||
| - id: account.id | |||
| type: string | |||
| brief: > | |||
| The cloud account ID used to identify different entities. | |||
| examples: ['opentelemetry'] | |||
| The cloud account ID the resource is created in. | |||
There was a problem hiding this comment.
Suggested change
| The cloud account ID the resource is created in. | |
| The cloud account ID the resource is assigned to. |
If a cloud provider allows moving resources between regions, I assume we don't want the original region.
arminru
approved these changes
Mar 1, 2021
|
PTAL |
carlosalberto
approved these changes
Mar 1, 2021
anuraaga
approved these changes
Mar 2, 2021
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide better examples representing account IDs, regions and zones
from non-GCP providers. Improve the description to explain the
relationship between resource and cloud attributes:
The resource is created or running in the account, region and zones.