Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rename cloud.zone to cloud.availability_zone #734

Merged
merged 1 commit into from
Apr 30, 2021
Merged

fix: Rename cloud.zone to cloud.availability_zone #734

merged 1 commit into from
Apr 30, 2021

Conversation

fbogsany
Copy link
Contributor

robbkidd
robbkidd approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ☁️ 🚀

@fbogsany
Copy link
Contributor Author

We need to add you to the approvers list @robbkidd 😉

robertlaurin
robertlaurin approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@robertlaurin robertlaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • lgtm

@fbogsany fbogsany merged commit 168b9fd into main Apr 30, 2021
@fbogsany fbogsany deleted the availability_zone branch January 21, 2022 20:06
@robbkidd robbkidd mentioned this pull request Jul 13, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlaurin robertlaurin robertlaurin approved these changes

@robbkidd robbkidd robbkidd approved these changes

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbogsany @robbkidd @robertlaurin