Improve reliability of tests #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
codeboten and
srikanthccv
and removed request for
a team
11 tasks
Update some tests to use more deterministic methods of testing in memory spans. This helps the core repo pass tests after adding Windows to CI matrix.
owais
force-pushed
the
more-deterministic-tests
branch
from
a783c60
to
dde62ce
Compare
aabmass
approved these changes
Aug 31, 2021
| self.assertEqual(2, len(spans)) | ||
| span1, span2 = spans | ||
| self.assertEqual(span1.name, "Elasticsearch/test-index") |
There was a problem hiding this comment.
This is not asserted by the span.by_name() call. It returns a span if found, otherwise throws an assertion error. Perhaps I should rename it to by_name_or_fail() or something?
There was a problem hiding this comment.
LMK if that makes sense. I can follow up with another PR.
| @@ -122,7 +122,8 @@ envlist = | |||
| py3{6,7,8,9}-test-instrumentation-grpc | |||
|
|
|||
| ; opentelemetry-instrumentation-sqlalchemy | |||
| py3{6,7,8,9}-test-instrumentation-sqlalchemy{11,14} | |||
| py3{6,7}-test-instrumentation-sqlalchemy{11} | |||
There was a problem hiding this comment.
Can you add a comment explaining why we do this?
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-python-contrib/pull/531/files#r696214503
Will add a comment to the file.
ocelotl
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update some tests to use more deterministic methods of testing in memory
spans. This helps the core repo pass tests after adding Windows to CI
matrix.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
This PR has been split out of #531 in order to not block the core Windows PR. We can merge core Windows PR along with this one and continue to work on contrib Windows.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.