Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let's do this (run tests on windows) #1889

Merged
merged 12 commits into from
Sep 1, 2021
Merged

let's do this (run tests on windows) #1889

merged 12 commits into from
Sep 1, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Jun 3, 2021 •
edited
Loading

Description

Fixes #910

Run core tests on Windows in addition to Ubuntu. Contrib tests will be enabled after the contrib repo enables windows tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Automated Tests

Does This PR Require a Contrib Repo Change?

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais force-pushed the test-on-windows branch 2 times, most recently from 53c9dea to af5682d Compare June 4, 2021 09:57
@owais owais added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 14, 2021
@owais owais force-pushed the test-on-windows branch 20 times, most recently from 41b2863 to e5261c7 Compare August 25, 2021 01:40
@owais owais marked this pull request as ready for review August 25, 2021 02:05
@owais owais requested review from a team, aabmass and ocelotl and removed request for a team August 25, 2021 02:05
@owais owais force-pushed the test-on-windows branch 3 times, most recently from c1130ed to 7ee8a1f Compare August 30, 2021 00:55
@owais
Copy link
Contributor Author

owais commented Aug 30, 2021

All builds (core+contrib) are passing but for some reason Github still expects some duplicate builds. I think this resulted from me renaming the build job in one of the iterations.

@owais owais requested a review from srikanthccv August 30, 2021 23:12
@owais owais mentioned this pull request Aug 31, 2021
Merged
8 tasks
@owais owais merged commit c1e8a51 into open-telemetry:main Sep 1, 2021
@owais owais deleted the test-on-windows branch September 1, 2021 20:18
@jeremydvoss jeremydvoss mentioned this pull request May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen Awaiting requested review from lzchen

@aabmass aabmass Awaiting requested review from aabmass

@ocelotl ocelotl Awaiting requested review from ocelotl

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests on Windows in CI
5 participants
@owais @ocelotl @aabmass @lzchen @srikanthccv