-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let's do this (run tests on windows) #1889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
test-on-windows
branch
2 times, most recently
from
June 4, 2021 09:57
53c9dea
to
af5682d
Compare
owais
force-pushed
the
test-on-windows
branch
20 times, most recently
from
August 25, 2021 01:40
41b2863
to
e5261c7
Compare
owais
requested review from
a team,
aabmass and
ocelotl
and removed request for
a team
August 25, 2021 02:05
owais
force-pushed
the
test-on-windows
branch
3 times, most recently
from
August 30, 2021 00:55
c1130ed
to
7ee8a1f
Compare
srikanthccv
approved these changes
Aug 30, 2021
All builds (core+contrib) are passing but for some reason Github still expects some duplicate builds. I think this resulted from me renaming the build job in one of the iterations. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approve Public API check
This label shows that the public symbols added or changed in a PR are strictly necessary
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #910
Run core tests on Windows in addition to Ubuntu. Contrib tests will be enabled after the contrib repo enables windows tests.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: