-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reliability of tests #643
Changes from all commits
71b0ca7
fa44875
c30a911
0041032
0dfcf1c
71cfb28
2a56c1d
9c9a9a6
03dccd9
32ed1da
dde62ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,7 +122,8 @@ envlist = | |
py3{6,7,8,9}-test-instrumentation-grpc | ||
|
||
; opentelemetry-instrumentation-sqlalchemy | ||
py3{6,7,8,9}-test-instrumentation-sqlalchemy{11,14} | ||
py3{6,7}-test-instrumentation-sqlalchemy{11} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment explaining why we do this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/open-telemetry/opentelemetry-python-contrib/pull/531/files#r696214503 Will add a comment to the file. |
||
py3{6,7,8,9}-test-instrumentation-sqlalchemy{14} | ||
pypy3-test-instrumentation-sqlalchemy{11,14} | ||
|
||
; opentelemetry-instrumentation-redis | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete this check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not asserted by the
span.by_name()
call. It returns a span if found, otherwise throws an assertion error. Perhaps I should rename it toby_name_or_fail()
or something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMK if that makes sense. I can follow up with another PR.