-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-instrumentation-falcon: expand supported version to v4 #3086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
you need to update pyproject.toml
file with the new version, runtox -e generate
and commit the changes. In that case, it's necessary to add tests to CI -- Add test-requirements.txt with the respective package version and include a new entry in tox.ini file
I'm writing a guideline in CONTRIBUTING.md to make this more clear.
EDIT: #3090 Some guidance here
@emdneto Thank you for the guidance! Please check out if it's now fix. I regerated the docs and tests according to your new PR. |
@stevapple Would be nice if you'll test things before opening PRs, thanks. |
It took some time as I failed to set up |
Falcon v4 has a mostly identical interface to v3, and is proved to be fully compatible with `opentelemetry-instrumentation-falcon`. Loose the version check to `<5.0.0` to avoid false `DependencyConflict` alarm.
81d2a66
to
22cf021
Compare
instrumentation/opentelemetry-instrumentation-falcon/test-requirements-3.txt
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py
Outdated
Show resolved
Hide resolved
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Description
Falcon v4 has a mostly identical interface to v3, and is proved to be fully compatible with
opentelemetry-instrumentation-falcon
. Loose the version check to<5.0.0
to avoid falseDependencyConflict
alarm, and fix the tests for v3.1.2+.Type of change
How Has This Been Tested?
Local testing shows that the package is compatible with Falcon v4.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.