Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing: add guidance on how to update package versions support #3090

Merged
merged 14 commits into from
Dec 18, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Dec 11, 2024

Description

Improve contributing guide to make explicit how to support new versions of instrumentation packages

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner December 11, 2024 00:49
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 11, 2024
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have some suggestions to clarify the location of where commands should run. Also here and everywhere else in this file, we should switch from backticking tox.ini to a link to it. This helps markdown link checker ensure there's not a typo there, also, readers can click it!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@xrmx xrmx merged commit 1ddba1b into open-telemetry:main Dec 18, 2024
573 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants