-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add official support to Python 3.13 #3134
Conversation
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
nit with context: I'm trying to figure out where I can contribute without asking, and I feel like I could do what I'm asking here. However, not sure it is my place or not. Is this also implicitly dropping 3.8? If so, maybe the changelog and PR title could be "Support Python 3.13 and drop testing of 3.8" I'm not sure what the "official" word means, I guess we meant we didn't prevent people from using it? |
@codefromthecrypt, thanks for your concern. It's important to note we are not dropping support for python3.8. We do still support 3.8 until 3.13. "Officially" supporting a Python version is defined here, and it basically means: "Now we are running tests at CI using this python version and we do care about issues of our packages when running with this version. We didn't prevent people from using it before, but now users have some guarantee that packages run fine with that version, and we support it. I hope that it makes sense to you, but let me know if there's something we can improve on the wording here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the help @emdneto. This in mind, I don't see any changes needed here.
Description
py313 issues
The only instrumentation we are not running py313 is pyramid. Will open a track issue for that:
Closes open-telemetry/opentelemetry-python#4211
Closes #2724