Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add official support to Python 3.13 #3134

Merged
merged 18 commits into from
Dec 31, 2024
Merged

add official support to Python 3.13 #3134

merged 18 commits into from
Dec 31, 2024

Conversation

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner December 20, 2024 19:56
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
emdneto and others added 7 commits December 23, 2024 10:19
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto marked this pull request as ready for review December 24, 2024 15:34
@emdneto emdneto requested a review from Kludex December 24, 2024 15:34
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@emdneto emdneto changed the title add py313 to tox add official support to Python 3.13 Dec 26, 2024
@codefromthecrypt
Copy link
Contributor

nit with context: I'm trying to figure out where I can contribute without asking, and I feel like I could do what I'm asking here. However, not sure it is my place or not.

Is this also implicitly dropping 3.8? If so, maybe the changelog and PR title could be

"Support Python 3.13 and drop testing of 3.8"

I'm not sure what the "official" word means, I guess we meant we didn't prevent people from using it?

@emdneto
Copy link
Member Author

emdneto commented Dec 27, 2024

nit with context: I'm trying to figure out where I can contribute without asking, and I feel like I could do what I'm asking here. However, not sure it is my place or not.

Is this also implicitly dropping 3.8? If so, maybe the changelog and PR title could be

"Support Python 3.13 and drop testing of 3.8"

I'm not sure what the "official" word means, I guess we meant we didn't prevent people from using it?

@codefromthecrypt, thanks for your concern. It's important to note we are not dropping support for python3.8. We do still support 3.8 until 3.13.

"Officially" supporting a Python version is defined here, and it basically means: "Now we are running tests at CI using this python version and we do care about issues of our packages when running with this version. We didn't prevent people from using it before, but now users have some guarantee that packages run fine with that version, and we support it. I hope that it makes sense to you, but let me know if there's something we can improve on the wording here.

tox.ini Outdated Show resolved Hide resolved
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the help @emdneto. This in mind, I don't see any changes needed here.

@emdneto emdneto requested a review from Kludex December 30, 2024 11:33
@Kludex Kludex mentioned this pull request Dec 31, 2024
10 tasks
@xrmx xrmx enabled auto-merge (squash) December 31, 2024 15:38
@xrmx xrmx merged commit 5488287 into open-telemetry:main Dec 31, 2024
674 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for Python 3.13 support