Remove deprecated messages and fields from metrics #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
|
Do we have a green flag on the Collector side? Any components still referencing these fields that need to be fixed (other than pdata package)? |
|
I'd like to be a little more cautious before delivering this. I think once we have most languages up-to-date on the latest metrics specification. Specifically, since we asked SiGs to hold off on metrics until spec was more stable, I think we should also delay the deprecation removal policy on these just a bit. |
|
@jsuereth what is the problem if they have not moved? They will be forced to do this move when upgrade. |
MrAlias
reviewed
Nov 18, 2021
There was a problem hiding this comment.
From the stability definitions:
"stable" maturity APIs should not introduce backwards-incompatible changes more than once every twelve months, and will make every effort to provide compatibility bridges if at all possible.
These fields were marked deprecated 8 months ago. Is this change compatible with our stability guarantees?
|
@MrAlias yes since it was already "deprecated" when we marked the project stable. We can wait 12m if you think that helps, but I doubt. |
jmacd
approved these changes
Dec 6, 2021
tigrannajaryan
approved these changes
Dec 6, 2021
SGTM |
MrAlias
approved these changes
Dec 6, 2021
jsuereth
approved these changes
Dec 7, 2021
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jul 28, 2022
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jul 28, 2022
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jul 28, 2022
Revert "Remove deprecated messages and fields from metrics (open-telemetry#342)"
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Aug 15, 2022
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Aug 18, 2022
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
May 24, 2023
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 19, 2024
…metry#342)" This reverts commit 8ba33cc.
VinozzZ
pushed a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
…metry#342)" This reverts commit 8ba33cc.
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
…metry#342)" This reverts commit 8ba33cc.
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
…metry#342)" This reverts commit 8ba33cc.
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
…metry#342)" This reverts commit 8ba33cc.
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jul 1, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Jul 1, 2024
…metry#342)" This reverts commit 8ba33cc.
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-proto
that referenced
this pull request
Dec 10, 2024
…metry#342)" This reverts commit 8ba33cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com