Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Metrics "labels" to use "attributes" #293

Closed
nachoBonafonte opened this issue Feb 16, 2022 · 2 comments
Closed

Update Metrics "labels" to use "attributes" #293

nachoBonafonte opened this issue Feb 16, 2022 · 2 comments

Comments

@nachoBonafonte
Copy link
Member

It looks like there was a breaking changed where labels has been deprecated now in otel-proto and attributes should be used in it's place. This is the otel-js fix
@trevor-dialpad trevor-dialpad mentioned this issue Mar 11, 2022
Closed
@trevor-dialpad trevor-dialpad mentioned this issue May 12, 2022
Closed
@vvydier
Copy link
Contributor

vvydier commented May 12, 2022

Yes, once its approved and in the project, if you can test it with your version of the otel-collector and let me know if there are any issues. If there are no issues, we can close this one. Thanks

@nachoBonafonte
Copy link
Member Author

Version 1.1.3 fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvydier @nachoBonafonte