-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentelemetry/proto spec #294
Update opentelemetry/proto spec #294
Conversation
Ran protoc --swift_out=. opentelemetry/proto/*/v1/*.proto and made all of the definitions public
This is a draft because the metrics I'm posting from my client aren't being successfully picked up my the collector - I'm trying to figure out why that is so I can address it but I haven't found much to go off of so far. If anyone has any clue as to why these metrics won't be picked up by the opentelemetry-collector with OTLP/GRPC I'd appreciate any ideas. |
3a4f116
to
ac8d3d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 75.35% 74.45% -0.90%
==========================================
Files 361 361
Lines 22569 22789 +220
==========================================
- Hits 17006 16968 -38
- Misses 5563 5821 +258
Continue to review full report at Codecov.
|
A bit more details I have since posting this draft:
|
Fixed with: #300 |
A couple things done here:
This should solve #293