Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTLP 1.x #119

Closed
mx-psi opened this issue May 23, 2024 · 2 comments
Closed

Support OTLP 1.x #119

mx-psi opened this issue May 23, 2024 · 2 comments
Assignees

Comments

@mx-psi
Copy link

mx-psi commented May 23, 2024

Based on the submodule named 'proto' on the top-level folder of this repository, it looks like the OTLP proto definitions are based on open-telemetry/opentelemetry-proto@b43e9b1, i.e. v0.11.0 from October 2021. This means that the current generated datatypes (those in the 'otlp' folder) reference fields that no longer exist in more recent OTLP versions.

For example, I can find this reference to IntGauge:

which was removed in v0.12.0 (specifically on open-telemetry/opentelemetry-proto/pull/342).

OTLP has since released a stable version, and some OpenTelemetry components no longer support v0.11.0 (e.g. the OpenTelemetry Collector dropped support for OTLP v0.11.0 in v0.44.0). In order to make this library work with the rest of the OpenTelemetry ecosystem, it would be necessary to bump the proto definitions

@iand675
Copy link
Owner

iand675 commented May 23, 2024

Thanks for raising this!

@michaelpj
Copy link
Collaborator

Fixed in #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants