Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move trace exporters back to experimental #2835

Merged
merged 11 commits into from
Mar 25, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 16, 2022

Move trace exporters back to experimental temporarily while we work on splitting the transformation logic out of the JSON exporter. This will break the experimental build because the exporters depend on the unreleased functionality in core. Once there is a stable release the experimental build will pass again. After we have a working release with the new split transformation logic we can release the proto/grpc exporters as stable.

@dyladan dyladan requested a review from a team March 16, 2022 10:56
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2835 (2ef36b9) into main (549bd5b) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2835      +/-   ##
==========================================
+ Coverage   93.19%   93.58%   +0.38%     
==========================================
  Files         157      120      -37     
  Lines        5117     4658     -459     
  Branches     1097     1046      -51     
==========================================
- Hits         4769     4359     -410     
+ Misses        348      299      -49     
Impacted Files Coverage Δ
...s/exporter-trace-otlp-http/src/OTLPExporterBase.ts
...packages/exporter-trace-otlp-http/src/transform.ts
...tal/packages/exporter-trace-otlp-http/src/types.ts
...ntal/packages/exporter-trace-otlp-http/src/util.ts
...etry-sdk-metrics-base/src/state/MetricCollector.ts
.../opentelemetry-sdk-metrics-base/src/Instruments.ts
...-metrics-base/examples/metrics/metrics/observer.js
...es/opentelemetry-sdk-metrics-base/src/view/View.ts
...sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
...telemetry-sdk-metrics-base/src/view/Aggregation.ts
... and 43 more

@dyladan dyladan marked this pull request as draft March 16, 2022 11:34
@dyladan
Copy link
Member Author

dyladan commented Mar 16, 2022

Marked as draft until #2836 is merged and a release is cut

@dyladan dyladan marked this pull request as ready for review March 18, 2022 08:48
@rauno56
Copy link
Member

rauno56 commented Mar 24, 2022

GHA seems to be acting up and not running CI. Perhaps the queues are long or something. Similar problems in contrib.

@Flarna
Copy link
Member

Flarna commented Mar 25, 2022

I finally got the build green for all node.js versions by using a mix of 1.1.0 and 1.0.0 components. Different NPM versions have a different dedup algorithm. as some experimental components depend on released 0.27.0 versions on NPM it's not possible as of now to get rid of API/SDK 1.0.

Therefore some followup tasks are needed but I would like to do this in different PRs:

  • get rid of the @opentelemetry/api-metrics-wip and @opentelemetry/sdk-metrics-base-wip to avoid depending on old releases of them on NPM
  • Update dependencies to API/Core and use proper version ranges

@dyladan
Copy link
Member Author

dyladan commented Mar 25, 2022

  • get rid of the @opentelemetry/api-metrics-wip and @opentelemetry/sdk-metrics-base-wip to avoid depending on old releases of them on NPM

Their package.json fields are marked as private so they have never been released and will never be released with those names. @pichlermarc is currently working on updating the OTLP metrics exporters to use the new data model and @legendecas is updating the prometheus. I believe these are the only modules depending on the metrics api/sdk so the names will be able to be switched back to the "real" names and they can be released as alpha when that is complete.

  • Update dependencies to API/Core and use proper version ranges

👍

@Flarna
Copy link
Member

Flarna commented Mar 25, 2022

I believe these are the only modules depending on the metrics api/sdk so the names will be able to be switched back to the "real" names and they can be released as alpha when that is complete.

dependencies on @opentelemetry/sdk-metrics-base (besides exporters)

  • @opentelemetry/otlp-transformer
  • @opentelemetry/sdk-node

dependencies on @opentelemetry/api-metrics (besides exporters)

  • @opentelemetry/instrumentation
  • @opentelemetry/instrumentation-grpc
  • @opentelemetry/otlp-transformer
  • @opentelemetry/sdk-node

As long as this is not cleaned we get old API/SDK versions into the experimental build.

@dyladan dyladan merged commit 16eaeb6 into open-telemetry:main Mar 25, 2022
@dyladan dyladan deleted the experimental-exporters branch March 25, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants