Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark trace exporters private to prevent publish #2836

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 16, 2022

This will prevent the exporters from being released when a stable release is cut. They can then be moved to experimental.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2836 (c0546e4) into main (4ca2d89) will not change coverage.
The diff coverage is n/a.

❗ Current head c0546e4 differs from pull request most recent head c842887. Consider uploading reports for the commit c842887 to get more accurate results

@@           Coverage Diff           @@
##             main    #2836   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         163      163           
  Lines        5543     5543           
  Branches     1167     1167           
=======================================
  Hits         5181     5181           
  Misses        362      362           

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can then be moved to experimental.
"They"?

Can you elaborate why we want to prevent publishing them?

@dyladan
Copy link
Member Author

dyladan commented Mar 16, 2022

They can then be moved to experimental.
"They"?

Can you elaborate why we want to prevent publishing them?

Discussed in slack but copying into the thread for others:

JSON format is the root of it. JSON format is not stable, therefore JSON exporter cannot be released stable. protobuf and gRPC exporters depend on JSON exporter to do the transformation logic. Do not want to release a stable exporter which depends on an experimental exporter.

@dyladan dyladan merged commit 038bbdb into open-telemetry:main Mar 16, 2022
@dyladan dyladan deleted the private-exporters branch March 16, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants