Update usage of semantic conventions to new exported strings

[JamieDanielson]

This is somewhat related to #1778 , which is for documenting current semantic convention versions for each instrumentation package.

This issue is intended to track the necessary change of updating each package to use the new exports for semantic conventions that were added in open-telemetry/opentelemetry-js#4298 and now available in v1.22.0.

Each package will need to

• update the dependency for @opentelemetry/semantic-conventions to "^1.22.0"
• update the imported semantic convention to match the new version, i.e. HTTP_ROUTE becomes SEMATTRS_HTTP_ROUTE

Please limit PRs to a single package in order to make them quickly and easily reviewable.
If you are working on one of the below packages, please comment so others know the issue is being worked on.

• @opentelemetry/instrumentation-amqplib refactor(instr-amqplib): use exported strings for attributes #2086
• @opentelemetry/instrumentation-cucumber refactor(instr-cucumber): use exported strings for attributes #2143
• @opentelemetry/instrumentation-dataloader
• @opentelemetry/instrumentation-fs chore(instrumentation-fs): remove unused semconv package #2141
• @opentelemetry/instrumentation-lru-memoizer docs: remove unused semconv packages and document #2182
• @opentelemetry/instrumentation-mongoose refactor(instr-mongoose): use exported strings for attributes #2103
• @opentelemetry/instrumentation-socket.io refactor(instr-socket.io): use exported strings for attributes #2147
• @opentelemetry/instrumentation-tedious refactor(instr-tedious): use exported strings for attributes #2144
• @opentelemetry/instrumentation-aws-lambda fix(aws-lambda): update semconv package and readme #2181
• @opentelemetry/instrumentation-aws-sdk refactor(instr-aws-sdk): use exported strings for attributes #2142
• @opentelemetry/instrumentation-bunyan chore(instrumentation-bunyan): use strings exported for attributes #2195
• @opentelemetry/instrumentation-cassandra-driver refactor(instr-cassandra-driver): use exported strings for attributes #2139
• @opentelemetry/instrumentation-connect refactor(instr-connect): use exported strings for attributes #2154
• @opentelemetry/instrumentation-dns docs: remove unused semconv packages and document #2182
• @opentelemetry/instrumentation-express chore(instr-express): use exported strings for attributes #2031
• @opentelemetry/instrumentation-fastify refactor(instr-fastify): use exported strings for attributes #2078
• @opentelemetry/instrumentation-generic-pool docs: remove unused semconv packages and document #2182
• @opentelemetry/instrumentation-graphql refactor(instr-graphql): use exported strings for attributes #2156
• @opentelemetry/instrumentation-hapi chore(instrumentation-hapi): use exported strings for attributes #2190
• @opentelemetry/instrumentation-ioredis chore(instrumentation-ioredis): use exported strings for attributes #2191
• @opentelemetry/instrumentation-knex refactor(instr-knex): use exported strings for attributes #2109
• @opentelemetry/instrumentation-koa feat(koa): Use exported strings for attributes #2033
• @opentelemetry/instrumentation-memcached chore(instrumentation-memcached): use exported strings for attributes #2192
• @opentelemetry/instrumentation-mongodb refactor(instr-mongodb): use exported strings for attributes #2088
• @opentelemetry/instrumentation-mysql refactor(instr-mysql): update semantic conventions #2112
• @opentelemetry/instrumentation-mysql2 refactor(instr-mysql2): use exported strings for attributes #2115
• @opentelemetry/instrumentation-nestjs-core chore(instrumentation-nestjs-core): use strings exported for attributes #2193
• @opentelemetry/instrumentation-net chore(instrumentation-net): use strings exported for attributes #2194
• @opentelemetry/instrumentation-pg chore(opentelemetry-instrumentation-pg): use exported strings  #2053
• @opentelemetry/instrumentation-pino docs: remove unused semconv packages and document #2182
• @opentelemetry/instrumentation-redis-4 refactor(instr-redis-4): use exported strings for attributes #2100
• @opentelemetry/instrumentation-redis refactor(instrumentation-redis): Use exported semconv strings #2075
• @opentelemetry/instrumentation-restify refactor(instr-restify): use exported strings for attributes #2098
• @opentelemetry/instrumentation-router refactor(instr-router): use exported strings for attributes #2099
• @opentelemetry/instrumentation-winston docs: remove unused semconv packages and document #2182
• @opentelemetry/instrumentation-document-load refactor(instr-document-load): use exported strings for semconv #2039
• @opentelemetry/instrumentation-long-task
• @opentelemetry/instrumentation-user-interaction
• @opentelemetry/instrumentation-undici as a new instrumentation, this has a different semantic convention package

EDIT: updated to add other packages that will need replacements for the deprecated attributes:

• @opentelemetry/browser-extension-autoinjection (skipping because this package is archived)
• @opentelemetry/resource-detector-alibaba-cloud chore(resource-detector-alibaba): use exported strings for attributes #2046
• @opentelemetry/resource-detector-aws chore(resource-detector-aws): use exported strings for attributes #2047
• @opentelemetry/resource-detector-azure chore(resource-detector-azure): use exported strings for attributes #2048
• @opentelemetry/resource-detector-container chore(resource-detector-container): use exported strings for attributes #2049
• @opentelemetry/resource-detector-gcp chore(resource-detector-gcp): use exported strings for attributes #2050
• @opentelemetry/resource-detector-instana chore(resource-detector-instana): use exported strings for attributes #2051
• examples/connect chore(examples/connect): use exported strings for attributes #2120
• examples/express chore(examples/express): use exported strings for attributes #2121
• examples/fastify
• examples/graphql chore(examples/graphql): use exported strings for attributes #2122
• examples/web chore(examples/web): use exported strings for attributes #2129
• @opentelemetry/sampler-aws-xray docs: remove unused semconv packages and document #2182
• @opentelemetry/contrib-test-utils chore(test-utils): update semantic resource attributes #2080
• @opentelemetry/plugin-react-load docs: remove unused semconv packages and document #2182
• examples/memcached chore(examples/memcached): use exported strings for attributes #2124
• examples/mongodb chore(examples/mongodb): use exported strings for attributes #2125
• examples/mysql chore(examples/mysql): use exported strings for attributes #2126
• examples/react-load chore(examples/react-load): use exported strings for attributes #2127
• examples/redis chore(examples/redis): use exported strings for attributes #2128

[JamieDanielson]

I am updating the express package

[MrFabio]

I am updating the koa package #2033

[JamieDanielson]

Updating instrumentation-document-load package #2039

[maryliag]

I am updating all the resource detector packages

[maryliag]

also updated the instrumentation-pg plugin

[JamieDanielson]

Also! A great follow-up PR (or maybe even the same PR, depending on how big the PR is) is to add the attributes to the README as listed in this issue #1778 . As an example, check out open-telemetry/opentelemetry-js#4587 😄

[maryliag]

I can do that for the ones I updated. I will do on a follow PRs, because I currently have a few PRs up updating those same README files and want to avoid the conflict. So once those are merged I will update with the missing info for this.

[JamieDanielson]

For a smaller list, these are remaining packages that still need to get updated in this repo:

• @opentelemetry/instrumentation-bunyan (dev dep)
• @opentelemetry/instrumentation-hapi
• @opentelemetry/instrumentation-ioredis
• @opentelemetry/instrumentation-memcached
• @opentelemetry/instrumentation-nestjs-core
• @opentelemetry/instrumentation-net
• @opentelemetry/instrumentation-long-task
• @opentelemetry/instrumentation-user-interaction
• @opentelemetry/browser-extension-autoinjection (this is archived, do we still need to update it?)

[JamieDanielson]

These packages do not seem to have semantic conventions; I am opening a PR for them to document as such and remove any unused semantic-convention packages

• @opentelemetry/instrumentation-lru-memoizer

• @opentelemetry/instrumentation-dns

• @opentelemetry/instrumentation-generic-pool

• @opentelemetry/instrumentation-pino

• @opentelemetry/instrumentation-winston

• @opentelemetry/plugin-react-load

• @opentelemetry/sampler-aws-xray

• done in docs: remove unused semconv packages and document #2182

[maryliag]

Updated the ones from your latest list:

• chore(instrumentation-hapi): use exported strings for attributes #2190
• chore(instrumentation-ioredis): use exported strings for attributes #2191
• chore(instrumentation-memcached): use exported strings for attributes #2192
• chore(instrumentation-nestjs-core): use strings exported for attributes #2193
• chore(instrumentation-net): use strings exported for attributes #2194
• chore(instrumentation-bunyan): use strings exported for attributes #2195

I didn't update long-task and user-interaction because I didn't actually see any usage of the semantic convention package on then, maybe am I missing something?
Also, don't think we should update an archived package, so I didn't do the extension-autoinjection

Seems to be some errors with the tests on the hapi one, I will try to look into it when I get some time

[trentm]

Remaining hits:

% rg SemanticAttributes -g '!instrumentation-undici' -w
plugins/node/opentelemetry-instrumentation-hapi/src/utils.ts
18:import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
80:        [SemanticAttributes.HTTP_ROUTE]: route.path,
81:        [SemanticAttributes.HTTP_METHOD]: route.method,
90:      [SemanticAttributes.HTTP_ROUTE]: route.path,
91:      [SemanticAttributes.HTTP_METHOD]: route.method,

plugins/node/instrumentation-socket.io/test/utils.ts
20:import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
60:    s => s.attributes[SemanticAttributes.MESSAGING_SYSTEM] === 'socket.io'

plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v5-v6.test.ts
47:import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
340:              mongoSpan!.attributes[SemanticAttributes.DB_STATEMENT] as string
386:                mongoSpan!.attributes[SemanticAttributes.DB_STATEMENT] as string

plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v4.test.ts
38:import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
337:              mongoSpan!.attributes[SemanticAttributes.DB_STATEMENT] as string
383:                mongoSpan!.attributes[SemanticAttributes.DB_STATEMENT] as string

plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb-v3.test.ts
36:import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
298:              mongoSpan!.attributes[SemanticAttributes.DB_STATEMENT] as string
344:                mongoSpan!.attributes[SemanticAttributes.DB_STATEMENT] as string
583:                mongoSpan.attributes[SemanticAttributes.NET_PEER_NAME],
587:                mongoSpan.attributes[SemanticAttributes.NET_PEER_PORT],

plugins/node/opentelemetry-instrumentation-mongodb/test/utils.ts
18:import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
96:    mongoSpan.attributes[SemanticAttributes.DB_OPERATION],
100:    mongoSpan.attributes[SemanticAttributes.DB_SYSTEM],
104:    mongoSpan.attributes[SemanticAttributes.NET_PEER_NAME],
110:      mongoSpan.attributes[SemanticAttributes.DB_CONNECTION_STRING],
117:      mongoSpan.attributes[SemanticAttributes.DB_STATEMENT] as string

So looks like instr-mongodb and instr-socket.io missed a couple usages in tests. And then the instr-hapi PR to complete

[trentm]

Remaining hits:

I've opened #2210 (review) for the last remaining uses.

[trentm]

I believe this is done now.