-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(instr-knex): use exported strings for attributes #2109
refactor(instr-knex): use exported strings for attributes #2109
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 90.97% 90.76% -0.22%
==========================================
Files 146 148 +2
Lines 7492 7675 +183
Branches 1502 1539 +37
==========================================
+ Hits 6816 6966 +150
- Misses 676 709 +33
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks like it's missing the update to package.json
and package-lock.json
🙂
Indeed! thanks for the heads up :) |
Which problem is this PR solving?
Short description of the changes
SemanticAttributes.*
with exported stringsSEMATTRS_*