-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instrumentation-net): use strings exported for attributes #2194
Conversation
Update strings exported for Resource Attributes Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
- Coverage 90.97% 90.46% -0.52%
==========================================
Files 146 149 +3
Lines 7492 7592 +100
Branches 1502 1591 +89
==========================================
+ Hits 6816 6868 +52
- Misses 676 724 +48
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the intent to add the ## Semantic Conventions
section with the attributes table to the README in this PR (and in some of the other PRs in this round) or to do that separately?
updated the readme (on this PR and the other ones too) |
@@ -59,7 +59,7 @@ | |||
}, | |||
"dependencies": { | |||
"@opentelemetry/instrumentation": "^0.51.0", | |||
"@opentelemetry/semantic-conventions": "^1.0.0" | |||
"@opentelemetry/semantic-conventions": "^1.23.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
"@opentelemetry/semantic-conventions": "^1.23.0" | |
"@opentelemetry/semantic-conventions": "^1.22.0" |
Thought perhaps I'm wrong and 1.23 is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as the other PR, I decided to get the latest version, since it also works
Which problem is this PR solving?
Short description of the changes
On package
opentelemetry-instrumentation-net
:@opentelemetry/semantic-conventions
^1.23.0