-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semconvutil and use it instead of httpconv and netconv #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3817 +/- ##
=======================================
+ Coverage 70.1% 79.3% +9.2%
=======================================
Files 149 163 +14
Lines 7133 10325 +3192
=======================================
+ Hits 5004 8196 +3192
Misses 1998 1998
Partials 131 131
|
pellared
added
the
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
label
May 16, 2023
pellared
changed the title
Add semconvutil based on semconv/v1.18.0
Add semconvutil and use it instead of httpconv and netconv
May 16, 2023
pellared
commented
May 16, 2023
pellared
commented
May 16, 2023
pellared
requested review from
Aneurysm9,
dmathieu and
hanyuancheung
as code owners
May 16, 2023 14:30
pellared
commented
May 17, 2023
instrumentation/github.com/emicklei/go-restful/otelrestful/internal/gen.go
Outdated
Show resolved
Hide resolved
MrAlias
reviewed
May 18, 2023
instrumentation/github.com/emicklei/go-restful/otelrestful/internal/gen.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/emicklei/go-restful/otelrestful/internal/gen.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/doc.go
Outdated
Show resolved
Hide resolved
pellared
commented
May 18, 2023
pellared
commented
May 18, 2023
pellared
commented
May 18, 2023
pellared
commented
May 18, 2023
dmathieu
approved these changes
May 22, 2023
MadVikingGod
approved these changes
May 22, 2023
MrAlias
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards open-telemetry/opentelemetry-go#4081 (point 1)
Closes open-telemetry/opentelemetry-go#3744
It will make updating
semconv
in https://github.com/open-telemetry/opentelemetry-go a lot easier. This repo will only contain the "currently used" semconv code. Updating to newer will also be easier as we will change existing code instead of generating new code.What
semconvutil
as a internal shared package which is not to be published (Go templates).semconvutil
package (viago generate
+gotmpl
) and use it instead ofhttpconv
andnetconv
packages which are planned to be deprecated.The "copy package" via go generate approach is used in order to not introduce dependencies between modules. More: open-telemetry/opentelemetry-go#3846