Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Run generate before lint #3819

Merged
merged 6 commits into from
May 17, 2023
Merged

[chore] Run generate before lint #3819

merged 6 commits into from
May 17, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented May 17, 2023 •
edited
Loading

The code generation should be executed before linting.

Addresses #3817 (comment)

@pellared pellared changed the title [chore] Generate before lint [chore] Run generate before lint May 17, 2023
@pellared pellared marked this pull request as ready for review May 17, 2023 08:34
@pellared pellared requested a review from a team May 17, 2023 08:34
@pellared pellared mentioned this pull request May 17, 2023
Merged
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #3819 (8cd5047) into main (3ab8efc) will not change coverage.
The diff coverage is n/a.

❗ Current head 8cd5047 differs from pull request most recent head 4671e9f. Consider uploading reports for the commit 4671e9f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3819   +/-   ##
=====================================
  Coverage   70.1%   70.1%           
=====================================
  Files        149     149           
  Lines       7133    7133           
=====================================
  Hits        5004    5004           
  Misses      1998    1998           
  Partials     131     131

see 4 files with indirect coverage changes

@MrAlias
Copy link
Contributor

MrAlias commented May 17, 2023

This is a tooling change that is blocking other PRs. Merging prior to 1 working day requirements.

@MrAlias MrAlias merged commit 95167fd into open-telemetry:main May 17, 2023
@pellared pellared deleted the generate-before-lint branch May 17, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pellared @MrAlias @dmathieu