semconv: Stop generating httpconv.go, netconv.go, http.go #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pellared
changed the title
pellared
changed the title
pellared
commented
May 29, 2023
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
pellared
changed the title
pellared
commented
May 29, 2023
MrAlias
approved these changes
May 30, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
dmathieu
approved these changes
Jun 2, 2023
dmathieu
reviewed
Jun 2, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4145 +/- ##
=====================================
Coverage 83.3% 83.3%
=====================================
Files 181 181
Lines 13928 13928
=====================================
Hits 11615 11615
Misses 2092 2092
Partials 221 221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next (and last) step after open-telemetry/opentelemetry-go-contrib#3817
Fixes #4081